Skip to content

Conversation

brianteeman
Copy link
Contributor

@brianteeman brianteeman commented Oct 12, 2025

Pull Request for Issue #46271 .

Summary of Changes

Changes a space to a tab to ensure that all columns are separated by a tab.

Testing Instructions

Code Review

Actual result BEFORE applying this Pull Request

The priotiy and ip address columns have a space as a separator when all the other columns are tab separated

Expected result AFTER applying this Pull Request

All columns are tab separated

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

Changes a space to a tab

Signed-off-by: BrianTeeman <[email protected]>
@alikon
Copy link
Contributor

alikon commented Oct 12, 2025

I have tested this item ✅ successfully on c46fe44


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46273.

@heelc29
Copy link
Contributor

heelc29 commented Oct 12, 2025

The same here?

'text_entry_format' => '{DATETIME} {PRIORITY} {CLIENTIP} {MESSAGE}',

@brianteeman
Copy link
Contributor Author

Not at my pc but if that's also mixed spaces and tabs then please open a new issue

@heelc29
Copy link
Contributor

heelc29 commented Oct 12, 2025

I do a quick test ... yes it looks like
image

then please open a new issue

Isn't it easier to integrate this into your PR since it's the same mistake

Signed-off-by: BrianTeeman <[email protected]>
@brianteeman
Copy link
Contributor Author

added webauthn log

@heelc29
Copy link
Contributor

heelc29 commented Oct 12, 2025

I have tested this item ✅ successfully on 16d123c

added webauthn log

thanks


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46273.

@sergeytolkachyov
Copy link
Contributor

I have tested this item ✅ successfully on 16d123c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46273.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46273.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Oct 13, 2025
@richard67 richard67 added this to the Joomla! 5.4.1 milestone Oct 13, 2025
@muhme
Copy link
Contributor

muhme commented Oct 17, 2025

Final check before merge: ✅ All spaces are replaces by tabs.

@brianteeman And is it not better to use \t as in other places? This would be clearly visible when reading the code in any case (independed from editor and configuration). After applying the PR, we could search and find:

find . -name \*.php | xargs grep "{MESSAGE}" | sed 's/\t/→/g'           
./plugins/system/webauthn/src/Extension/Webauthn.php:            'text_entry_format' => '{DATETIME}→{PRIORITY}→{CLIENTIP}→{MESSAGE}',
./libraries/src/Log/Logger/FormattedtextLogger.php:    protected $format = '{DATETIME}→{PRIORITY}→{CLIENTIP}→{CATEGORY}→{MESSAGE}';
./libraries/src/Log/Logger/W3cLogger.php:    protected $format = '{DATE}→{TIME}→{PRIORITY}→{CLIENTIP}→{CATEGORY}→{MESSAGE}';
./installation/includes/app.php:            'format'    => '{DATE}\t{TIME}\t{LEVEL}\t{CODE}\t{MESSAGE}',
./installation/includes/cli.php:            'format'    => '{DATE}\t{TIME}\t{LEVEL}\t{CODE}\t{MESSAGE}',
./administrator/components/com_scheduler/src/Scheduler/Scheduler.php:        $options['text_entry_format'] = '{DATE}→{TIME}→{PRIORITY}→{MESSAGE}';
./administrator/components/com_scheduler/src/Task/Task.php:            $options['text_entry_format'] = '{DATE}→{TIME}→{PRIORITY}→{MESSAGE}';
./administrator/components/com_joomlaupdate/src/Model/UpdateModel.php:            'format'    => '{DATE}\t{TIME}\t{LEVEL}\t{CODE}\t{MESSAGE}',
./administrator/components/com_finder/src/Response/Response.php:            $options['format']    = '{DATE}\t{TIME}\t{LEVEL}\t{CODE}\t{MESSAGE}';
./administrator/components/com_finder/src/Controller/IndexerController.php:            $options['format']    = '{DATE}\t{TIME}\t{LEVEL}\t{CODE}\t{MESSAGE}';
./administrator/components/com_finder/src/Controller/IndexerController.php:            $options['format']    = '{DATE}\t{TIME}\t{LEVEL}\t{CODE}\t{MESSAGE}';
./administrator/components/com_finder/src/Controller/IndexerController.php:            $options['format']    = '{DATE}\t{TIME}\t{LEVEL}\t{CODE}\t{MESSAGE}';

@richard67 richard67 merged commit 28fb593 into joomla:5.4-dev Oct 17, 2025
40 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Oct 17, 2025
@richard67
Copy link
Member

Thanks all (author and testers).

@brianteeman brianteeman deleted the tab_not_space branch October 17, 2025 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants