[5.4] Update repeatable-table.php #46287
Open
+4
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The <th> width was hardcoded to 45%, regardless of the number of columns. This change makes it dynamic, distributing the width according to the number of fields, while reserving 8% for the action column.
richard67
reviewed
Oct 15, 2025
richard67
reviewed
Oct 15, 2025
Co-authored-by: Richard Fath <[email protected]>
richard67
changed the title
|
Tested and works perfectly. |
Fedik
reviewed
Oct 17, 2025
| $fields = $tmpl->getGroup(''); | ||
|
|
||
| foreach ($fields as $field) { | ||
| $table_head .= '<th scope="col" style="width:' . (92 / count($fields)) . '%">' . strip_tags($field->label); |
There was a problem hiding this comment.
please calculate width once before "foreach" call,
no need to do it for every field, result will be the same
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
The width was hardcoded to 45%, regardless of the number of columns. This change makes it dynamic, distributing the width according to the number of fields, while reserving 8% for the action column.
Testing Instructions
Create a subform 'test' field with a repeatable.table layout and at least 3 (text for eg.) fields in it.
(layout="joomla.form.field.subform.repeatable-table") + subform_test.xml
Actual result BEFORE applying this Pull Request
2 first fields have 45% as width and the 3rd and following ones are compressed
Expected result AFTER applying this Pull Request
the width of ech field is a divisiion of the total width per the amount of fields
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed