reject double dot after optional chaining operator, etc. #3585
+88
−36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Don't ignore ?. between expressions that can be implicitly multiplied
2. Allow an undefined function in optional chaining function call,
by whatever means that function was generated.
3. Disallow optional chaining assignment.
Adds tests for all three.
|
Since @AnslemHack had fixed one problem recently found, it was most convenient to use this PR as a base for fixes to the three additional problems with optional chaining that I found while reviewing this PR. (I hope nobody involved minds -- if you want me to revert and file a separate PR I would be happy to instead.) Anyhow, now this PR: Funny how code (e.g. look in parseAccessors in src/expressions/parse.js) can actually become simpler by fixing bugs. Anyhow, now that I've changed a bunch in parseAccessors, another maintainer (likely @josdejong, especially since he was planning to anyway) should review this, not me any further. |
gwhitney
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3585 where mathjs incorrectly accepts ?.. (double-dot after optional chaining), which is invalid in JavaScript.