Skip to content

Conversation

adry84
Copy link

@adry84 adry84 commented May 21, 2025

This PR adds the option "allow-selection-edition" to allow editing the selection and fixes deleting the selection when clicking the selected option again (only visible with the new option to true > cf screen-cast using demo app).

I realize that the option will need to be de-select if the user edits it with a new value. I still need to correct this.

But what do you think about adding this option?

ScreencastSelectionRemovedOnReSelect.webm
ScreencastBehaviorWithAllowSelectionEdition.webm
ScreencastEscapeStrangeBehavior.webm

@adry84 adry84 marked this pull request as draft May 21, 2025 10:12
@joshhanley
Copy link
Owner

@adry84 thanks for the PR! Sorry, but I don't understand what this is. Can explain to me what the scenario is? What you're trying to achieve and what the autocomplete can't do currently?

@adry84
Copy link
Author

adry84 commented May 23, 2025

Hello @joshhanley, thank you for looking at this PR and sorry it's unclear.
The goal here is to allow editing the selected option in the input field instead of having to always delete it and rewrite it entirely.

Exemple:

  • I have an option list with option1, option2, option3
  • I select the "option1" in the dropdown
    Currently the input field is disabled and I have to click on the cross to select another option.
    I would like not to disable the field to directly delete 1 and replace it with 2 for example.
  • So the dropdown will allow me to directly select option 2 instead of re-displaying all the options.

Is this more understandable?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants