Skip to content

Conversation

@Cleboost
Copy link
Contributor

@Cleboost Cleboost commented Jun 29, 2025

Updated the sidebar menu to display icons next to each link (Home, Tracks, Albums, Podcasts) by modifying the sidebar_link_widget to accept and render an optional icon.

{3A1B3B7D-F50E-4F58-AA27-4DE1B34D9E55}
{C595643F-FB48-4874-AFA5-8A1EC34E8A46}

Cleboost added 3 commits June 29, 2025 11:15
Updated the sidebar menu to display icons next to each link (Home, Tracks, Albums, Podcasts) by modifying the sidebar_link_widget to accept and render an optional icon.
Refactored the search input widget to include a search icon and improved padding, background, and border styling for better UI consistency. Utilized a Container and Flex layout to align the icon and input field, and applied theme-based color adjustments.
Replaces usage of SELECTION_COLOR with SELECTED_TEXT_BACKGROUND_COLOR in the search input widget. Also removes unused imports for Overlay and Env to clean up the code.
@jacksongoode
Copy link
Collaborator

Just a passing thought, the icons on the left of the sections are a nice touch. I'm not so sure about any of the changes to the search bar... I think having more space to use for your search query would be better than an icon.

@Cleboost
Copy link
Contributor Author

I was also unsure about the search bar, but I still included it in the proposal; I can always revert it based on the feedback.

@jacksongoode
Copy link
Collaborator

My feeling is that we should revert, it can always be another PR. I'd approve to add them since they are immediately more descriptive.

I'd also like @SO9010 thought on adding these icons as well.

@SO9010
Copy link
Collaborator

SO9010 commented Jun 30, 2025

Good idea, but I think it should be an option in settings to enable/disable it as I personally wouldn't want it as I I like just the test on the sidebar. But it could be an auto opt in feature.

@Cleboost
Copy link
Contributor Author

Cleboost commented Jun 30, 2025

Good idea, but I think it should be an option in settings to enable/disable it as I personally wouldn't want it as I I like just the test on the sidebar. But it could be an auto opt in feature.

If the PR is merged, I will submit a separate PR to introduce compact mode for the whole application. #663

I think the option can be compact mode

@Cleboost
Copy link
Contributor Author

My feeling is that we should revert, it can always be another PR. I'd approve to add them since they are immediately more descriptive.

I'd also like @SO9010 thought on adding these icons as well.

I will revert

@SO9010
Copy link
Collaborator

SO9010 commented Jun 30, 2025

If the PR is merged, I will submit a separate PR to introduce compact mode for the whole application. l

I'm a big fan of this idea! The compact mode could also have sub settings such as removing the info parts of say playlists and podcasts. Or changing the padding too? What do you think @jacksongoode

@jacksongoode
Copy link
Collaborator

I think it should be an option in settings to enable/disable

Hm yeah, I think we could sneak it under the show/hide covers.

As for other customization, since minimalism is the ethos of Psst (I feel). I wouldn't want to provide so much user facing customization given that it would also likely lead to breaking the interface. I think visual changes should be made sparingly and thoughtfully - though I'm not opposed to providing a stylesheet/config file that people could fiddle with all the constants at their own peril if they so desire.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants