- 
                Notifications
    
You must be signed in to change notification settings  - Fork 250
 
Add icons to sidebar menu links #661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Updated the sidebar menu to display icons next to each link (Home, Tracks, Albums, Podcasts) by modifying the sidebar_link_widget to accept and render an optional icon.
Refactored the search input widget to include a search icon and improved padding, background, and border styling for better UI consistency. Utilized a Container and Flex layout to align the icon and input field, and applied theme-based color adjustments.
Replaces usage of SELECTION_COLOR with SELECTED_TEXT_BACKGROUND_COLOR in the search input widget. Also removes unused imports for Overlay and Env to clean up the code.
| 
           Just a passing thought, the icons on the left of the sections are a nice touch. I'm not so sure about any of the changes to the search bar... I think having more space to use for your search query would be better than an icon.  | 
    
| 
           I was also unsure about the search bar, but I still included it in the proposal; I can always revert it based on the feedback.  | 
    
| 
           My feeling is that we should revert, it can always be another PR. I'd approve to add them since they are immediately more descriptive. I'd also like @SO9010 thought on adding these icons as well.  | 
    
| 
           Good idea, but I think it should be an option in settings to enable/disable it as I personally wouldn't want it as I I like just the test on the sidebar. But it could be an auto opt in feature.  | 
    
          
 
 I think the option can be compact mode  | 
    
          
 I will revert  | 
    
          
 I'm a big fan of this idea! The compact mode could also have sub settings such as removing the info parts of say playlists and podcasts. Or changing the padding too? What do you think @jacksongoode  | 
    
          
 Hm yeah, I think we could sneak it under the show/hide covers. As for other customization, since minimalism is the ethos of Psst (I feel). I wouldn't want to provide so much user facing customization given that it would also likely lead to breaking the interface. I think visual changes should be made sparingly and thoughtfully - though I'm not opposed to providing a stylesheet/config file that people could fiddle with all the constants at their own peril if they so desire.  | 
    
Updated the sidebar menu to display icons next to each link (Home, Tracks, Albums, Podcasts) by modifying the sidebar_link_widget to accept and render an optional icon.