Skip to content

:focusable incorrectly requires tabindex on details and summary elements #1885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

:focusable incorrectly requires tabindex on details and summary elements #1885

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e71bb18
in $.ui.focusable, added <details> and <summary> to list of elements …
bbenjamin Mar 15, 2019
7a41217
only summary is added to the element list
bbenjamin Mar 29, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ui/focusable.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ $.ui.focusable = function( element, hasTabindex ) {
return img.length > 0 && img.is( ":visible" );
}

if ( /^(input|select|textarea|button|object)$/.test( nodeName ) ) {
if ( /^(input|select|textarea|button|object|details|summary)$/.test( nodeName ) ) {
focusableIfVisible = !element.disabled;

if ( focusableIfVisible ) {
Expand Down