ci: add nodejs v18 - v24 to test matrix #127
Open
+56
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Phillip9587
commented
Jun 19, 2025
| @@ -6,9 +6,21 @@ var util = require('util') | |||
|
|
|||
| var createError = require('..') | |||
|
|
|||
| // eslint-disable-next-line node/no-deprecated-api | |||
| var isError = typeof Error.isError === 'function' ? Error.isError : util.isError | |||
There was a problem hiding this comment.
util.isError reached EOL in Node v23 and Error.isError was introduced in Node 24 so we don't have a isError function in Node 23. We could use a instanceof Error check but i am not sure if we should or if we should just disable the test for Node 23.
There was a problem hiding this comment.
I'm in favor of using instanceof Error, I don't think we should disable the test.
|
v23 is failing |
Please take a look at my comment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the Node.js versions tested in the CI workflow to include newer releases.