Add more comprehensive tessts for A-labels in the "hostname" format #786
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since draft-07, the
hostnameformat has specified that it includes IDNA2008 A-labels and that all validhostnames should also be valididn-hostnames. That means that it's not enough forhostnames to be valid punycode, they also need to be able to decode to a valid U-label including all the complex rules involved. This PR adds an equivalent A-label test for all of the U-label tests from theidn-hostnameformat tests to thehostnameformat tests.I also did a little clean up. I found several tests issues including a few duplicate tests, incorrect test descriptions, and few other issues. I also reordered some of the tests so they were grouped logically. I did the clean in a separate commit to make review a little easier.