Skip to content

Fixing TOC bug in blogs #1745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 17, 2025
Merged

Conversation

idanidan29
Copy link
Collaborator

@idanidan29 idanidan29 commented Jun 28, 2025

What kind of change does this PR introduce?

Bugfix fixes incorrect entries in the blog Table of Contents (TOC)

Issue Number:

Screenshots/videos:

image

Summary

the issue was dealing with the Infobox element, by adding it to the hidden elements in the StyledMarkdown component we can remove it from the TOC

Does this PR introduce a breaking change?

no

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@idanidan29 idanidan29 requested a review from a team as a code owner June 28, 2025 15:31
Copy link

github-actions bot commented Jun 28, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
website ✅ Ready (View Log) Visit Preview 264ea3e

Copy link

codecov bot commented Jun 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (35f8a3e) to head (264ea3e).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1745   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           26        29    +3     
  Lines          523       548   +25     
  Branches       146       158   +12     
=========================================
+ Hits           523       548   +25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@idanidan29 idanidan29 changed the title adjusting the infobox into a blockquote Fixing TOC bug in blogs Jun 28, 2025
Copy link
Collaborator

@benjagm benjagm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benjagm benjagm merged commit be61dab into json-schema-org:main Jul 17, 2025
9 checks passed
@github-project-automation github-project-automation bot moved this from Ready to review to Done in PR - Triage Group Jul 17, 2025
@idanidan29 idanidan29 deleted the fixing-blog-TOC branch July 17, 2025 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

🐛 Bug: TOC in the new blog is filled with unreverent sentences
2 participants