adapting the JSON editor to ShadCN with improved styling + 3 issues resolved #1762
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @idanidan29! Thanks a lot for your contribution! I noticed that the following required information is missing or incomplete: completed checklist items Please update the PR description to include this information. You can find placeholders in the PR template for these items. Thanks a lot! |
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1762 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 29 30 +1
Lines 548 602 +54
Branches 158 179 +21
=========================================
+ Hits 548 602 +54 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
idanidan29
changed the title
idanidan29
changed the title
idanidan29
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Adapted the JSON editor component to use ShadCN and updated the Cypress tests accordingly also added tests for the alert UI element.
Now you can create partial schema JSON blocks using //partial schema at the top of the schema, instead of the default code blocks. Also, the default code block styling has been updated to match the JSON editor styling. also have fixed some bugs related the JSON editor inputs
Issue Number:
Screenshots/videos:
Summary
This PR improves the visual consistency and user experience of the JSON editor by integrating ShadCN components, enabling partial schema support via //partial schema, and refining the styling of code blocks to align with the editor. It also addresses several bugs related to input behavior.
Does this PR introduce a breaking change?
no
Checklist
Please ensure the following tasks are completed before submitting this pull request.