Skip to content

Migrate Sidebar and ScrollButton to ShadCN + issue resolved #1768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

idanidan29
Copy link
Collaborator

@idanidan29 idanidan29 commented Jul 10, 2025

What kind of change does this PR introduce?

  • Adapted 2 components to use the ShadCN library.
  • Created and adjusted Cypress test files for these 2 components, significantly improving code maintainability.
  • Adjusted for dark mode the scroll button
  • Made the hover effects and styling of the sidebar consistent with the sidebar on the Tools page.
  • Solved a bug issue

Issue Number:

Screenshots/videos:

image

A dark mode state have been added to the scroll button

image

Summary

This PR:

  • Migrated the existing Sidebar.tsx and ScrollButton.tsx components to the ShadCN library.
  • Enhanced the overall styling (add dark mode for the ScrollButton and made the sidebar styles consistent with the tools page sidebar).
  • Added Cypress tests for all implemented components to ensure reliability and behavior coverage.
  • solved a bug issue

Does this PR introduce a breaking change?

no

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@idanidan29 idanidan29 requested a review from a team as a code owner July 10, 2025 08:30
@github-project-automation github-project-automation bot moved this to Ready to review in PR - Triage Group Jul 10, 2025
@idanidan29 idanidan29 changed the title Phase 3.1 Migrate Sidebar and ScrollButton to ShadCN + issue resolved Jul 10, 2025
Copy link

github-actions bot commented Jul 10, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
website ✅ Ready (View Log) Visit Preview 14b9a2b

Copy link

codecov bot commented Jul 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (d585a99) to head (14b9a2b).

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1768   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           29        29           
  Lines          548       553    +5     
  Branches       158       161    +3     
=========================================
+ Hits           548       553    +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@idanidan29 idanidan29 added the GSoC Google Summer of Code related label Jul 10, 2025
@idanidan29
Copy link
Collaborator Author

idanidan29 commented Jul 11, 2025

There seems to be an issue with the test coverage report flagging partial coverage in the Layout, SiteLayout, and CarbonAds components. This PR doesn’t include any changes to those components, and they currently don’t have associated test files. For now, I’ve added the /* istanbul ignore file */ directive to them for preventing the flagging. These components are part of my upcoming tasks in the program and will be tested and adjusted in my next PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GSoC Google Summer of Code related
Projects
Status: Ready to review
Development

Successfully merging this pull request may close these issues.

🐛 Bug: Wrong toggle of arrows in Guide section
1 participant