-
Notifications
You must be signed in to change notification settings - Fork 42
Refactor projects page and add new projects #193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
This commit includes the following changes: - Refactored inline styles on the projects page (`apps/homepage2/app/projects/page.js`) to use CSS classes defined in a new `apps/homepage2/app/projects/projects.css` file. This improves code readability and maintainability. - Corrected grammar on the projects page: changed "resumes" to "résumés" and "repo" to "repository". - Added several new community projects to the list: - ResumeHub Theme - Astro JSON Resume - Lissy93 CV - Straightforward Theme - Updated the category and description for the existing 'jsonresume-nix' project to 'tooling' for better accuracy. - Added new categories 'theme' and 'tooling' to the projects page.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
WalkthroughThe changes introduce a new CSS stylesheet for project display, update and expand the list of projects with new entries and revised descriptions, reorganize project categories, and refactor the rendering of project items to use CSS classes instead of inline styles. Footer text and links are also updated for consistency. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant ProjectsPage
participant CSS
User->>ProjectsPage: Visit projects page
ProjectsPage->>CSS: Import and apply projects.css
ProjectsPage->>ProjectsPage: Render PROJECTS array with new/updated entries
ProjectsPage->>User: Display styled list of projects with updated info
Possibly related PRs
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
apps/homepage2/app/projects/projects.cssOops! Something went wrong! :( ESLint: 8.57.1 ESLint couldn't find the plugin "eslint-plugin-turbo". (The package "eslint-plugin-turbo" was not found when loaded as a Node module from the directory "/apps/homepage2".) It's likely that the plugin isn't installed correctly. Try reinstalling by running the following:
The plugin "eslint-plugin-turbo" was referenced from the config file in "apps/homepage2/.eslintrc.js » @repo/eslint-config-custom » eslint-config-turbo". If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team. apps/homepage2/app/projects/page.jsOops! Something went wrong! :( ESLint: 8.57.1 ESLint couldn't find the plugin "eslint-plugin-turbo". (The package "eslint-plugin-turbo" was not found when loaded as a Node module from the directory "/apps/homepage2".) It's likely that the plugin isn't installed correctly. Try reinstalling by running the following:
The plugin "eslint-plugin-turbo" was referenced from the config file in "apps/homepage2/.eslintrc.js » @repo/eslint-config-custom » eslint-config-turbo". If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team. Note ⚡️ AI Code Reviews for VS Code, Cursor, WindsurfCodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback. ✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (1)
apps/homepage2/app/projects/page.js (1)
169-169
: Fix typo in language field.There's a typo in the language field for the gatsby-portfolio project.
- language: 'Javscript', + language: 'Javascript',
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
apps/homepage2/app/projects/page.js
(13 hunks)apps/homepage2/app/projects/projects.css
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: build
🔇 Additional comments (8)
apps/homepage2/app/projects/projects.css (1)
1-22
: LGTM! Well-structured CSS refactoring.The CSS classes are well-designed with appropriate flexbox layout, proper spacing, and thoughtful constraints for different content types. This refactoring improves maintainability by separating styling from inline styles in the JavaScript component.
apps/homepage2/app/projects/page.js (7)
8-8
: LGTM! Proper CSS import added.The CSS import correctly references the new stylesheet for the project styling classes.
39-39
: Excellent consistency improvement!The systematic update from "resume" to "résumé" throughout the project descriptions improves consistency and uses the proper French accent as intended. This aligns well with the professional presentation of the projects page.
Also applies to: 47-47, 55-55, 71-71, 79-79, 86-86, 253-253, 261-261, 269-269, 277-277, 293-293, 323-323, 346-346, 361-361, 376-376
401-405
: Good categorization update.The description update and category change from "images" to "tooling" for jsonresume-nix is more accurate, as it provides development tooling rather than image generation.
422-449
: Well-formatted new project additions.The four new projects are properly structured with all required fields (name, description, link, category, language) and are appropriately categorized. The new "theme" category for ResumeHub Theme and Straightforward Theme is a logical addition.
452-469
: Good category organization improvements.The alphabetical ordering and addition of new categories ("ats", "theme", "tooling") provides better organization for the growing list of community projects.
477-483
: Successful refactoring to CSS classes.The rendering function has been properly updated to use the new CSS classes (
project-item
,project-name
,project-language
,project-description
) instead of inline styles, improving maintainability and consistency.
503-506
: Good text improvements in footer.The updates from "resumes" to "résumés" and "repo" to "repository" enhance the professional presentation and consistency with the rest of the page.
{ | ||
name: 'resume-optimizer', | ||
description: 'Use AI to ensure your resume passes ATS keyword screening.', | ||
description: 'Use AI to ensure your résumé passes ATS keyword screening.', | ||
link: 'https://github.com/panasenco/resume-optimizer', | ||
category: 'images', | ||
language: 'Nix', | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Verification agent
🧩 Analysis chain
Verify project categorization and language.
The "resume-optimizer" project appears to be miscategorized and has inconsistent metadata:
- Description mentions "AI" and "ATS keyword screening" but category is "images"
- Language is listed as "Nix" but the GitHub link suggests it's primarily Python-based
🏁 Script executed:
#!/bin/bash
# Description: Verify the resume-optimizer project details from its GitHub repository
# Check the repository to understand the primary language and purpose
curl -s https://api.github.com/repos/panasenco/resume-optimizer | jq '.language, .description, .topics'
# Check the repository files to understand the technology stack
curl -s https://api.github.com/repos/panasenco/resume-optimizer/languages | jq .
Length of output: 355
🏁 Script executed:
#!/bin/bash
# List unique project categories used in apps/homepage2/app/projects/page.js
rg "category: '.*'" -o apps/homepage2/app/projects/page.js | sed -E "s/.*category: '([^']+)'.*/\1/" | sort | uniq -c
Length of output: 389
Correct project categorization and language for resume-optimizer
Verified via GitHub API: the repo is primarily Python and centered on AI-powered résumé optimization. Please update the metadata accordingly.
• File: apps/homepage2/app/projects/page.js
Lines: 415–421
- {
- name: 'resume-optimizer',
- description: 'Use AI to ensure your résumé passes ATS keyword screening.',
- link: 'https://github.com/panasenco/resume-optimizer',
- category: 'images',
- language: 'Nix',
- },
+ {
+ name: 'resume-optimizer',
+ description: 'Use AI to ensure your résumé passes ATS keyword screening.',
+ link: 'https://github.com/panasenco/resume-optimizer',
+ category: 'ai',
+ language: 'Python',
+ },
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
{ | |
name: 'resume-optimizer', | |
description: 'Use AI to ensure your resume passes ATS keyword screening.', | |
description: 'Use AI to ensure your résumé passes ATS keyword screening.', | |
link: 'https://github.com/panasenco/resume-optimizer', | |
category: 'images', | |
language: 'Nix', | |
}, | |
{ | |
name: 'resume-optimizer', | |
description: 'Use AI to ensure your résumé passes ATS keyword screening.', | |
link: 'https://github.com/panasenco/resume-optimizer', | |
category: 'ai', | |
language: 'Python', | |
}, |
🤖 Prompt for AI Agents
In apps/homepage2/app/projects/page.js around lines 415 to 421, the
"resume-optimizer" project is incorrectly categorized as "images" and its
language is set to "Nix". Update the category to reflect its AI and résumé
optimization focus, such as "AI" or "productivity", and change the language to
"Python" to match the primary technology used in the GitHub repository.
PR Status: Needs Rebase This PR is significantly out of sync with Suggested Action: The new community projects and CSS refactoring in this PR are valuable, but need to be re-applied to the current codebase: Option 1: Rebase the branch git fetch origin master
git rebase origin/master
# Resolve conflicts Option 2: Create a fresh PR
Note: Some of these projects may have already been added in recent commits (checking projects page in master shows recent community additions). Would you like me to create a fresh PR with just the new projects that aren't already in master? |
This commit includes the following changes:
apps/homepage2/app/projects/page.js
) to use CSS classes defined in a newapps/homepage2/app/projects/projects.css
file. This improves code readability and maintainability.Summary by CodeRabbit
New Features
Style
Bug Fixes
Refactor