Skip to content

Conversation

thomasdavis
Copy link
Member

@thomasdavis thomasdavis commented May 24, 2025

This commit includes the following changes:

  • Refactored inline styles on the projects page (apps/homepage2/app/projects/page.js) to use CSS classes defined in a new apps/homepage2/app/projects/projects.css file. This improves code readability and maintainability.
  • Corrected grammar on the projects page: changed "resumes" to "résumés" and "repo" to "repository".
  • Added several new community projects to the list:
    • ResumeHub Theme
    • Astro JSON Resume
    • Lissy93 CV
    • Straightforward Theme
  • Updated the category and description for the existing 'jsonresume-nix' project to 'tooling' for better accuracy.
  • Added new categories 'theme' and 'tooling' to the projects page.

Summary by CodeRabbit

  • New Features

    • Added four new projects to the projects page.
    • Introduced new categories such as "theme," "tooling," and "ats" for better project organization.
  • Style

    • Improved the visual layout of project listings with new CSS styles for better readability and structure.
  • Bug Fixes

    • Standardized the spelling of "résumé" across project descriptions and the footer for consistency.
  • Refactor

    • Replaced inline styles with CSS class names for project items to streamline styling.

This commit includes the following changes:

- Refactored inline styles on the projects page (`apps/homepage2/app/projects/page.js`) to use CSS classes defined in a new `apps/homepage2/app/projects/projects.css` file. This improves code readability and maintainability.
- Corrected grammar on the projects page: changed "resumes" to "résumés" and "repo" to "repository".
- Added several new community projects to the list:
    - ResumeHub Theme
    - Astro JSON Resume
    - Lissy93 CV
    - Straightforward Theme
- Updated the category and description for the existing 'jsonresume-nix' project to 'tooling' for better accuracy.
- Added new categories 'theme' and 'tooling' to the projects page.
@changeset-bot
Copy link

changeset-bot bot commented May 24, 2025

⚠️ No Changeset found

Latest commit: 2f060b9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented May 24, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
jsonresume-org-homepage2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 24, 2025 6:42pm
jsonresume-org-registry ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 24, 2025 6:42pm

@coderabbitai
Copy link
Contributor

coderabbitai bot commented May 24, 2025

Walkthrough

The changes introduce a new CSS stylesheet for project display, update and expand the list of projects with new entries and revised descriptions, reorganize project categories, and refactor the rendering of project items to use CSS classes instead of inline styles. Footer text and links are also updated for consistency.

Changes

File(s) Change Summary
apps/homepage2/app/projects/page.js Imports new CSS, updates project descriptions, adds new projects, reorganizes categories, refactors rendering to use CSS classes, and updates footer text and links.
apps/homepage2/app/projects/projects.css Adds new CSS styles for project item layout and appearance.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant ProjectsPage
    participant CSS

    User->>ProjectsPage: Visit projects page
    ProjectsPage->>CSS: Import and apply projects.css
    ProjectsPage->>ProjectsPage: Render PROJECTS array with new/updated entries
    ProjectsPage->>User: Display styled list of projects with updated info
Loading

Possibly related PRs

Poem

In a meadow of code where projects bloom bright,
New entries and categories now come to light.
With accents on résumés and CSS in tow,
Each project stands prouder, in a well-ordered row.
A hop, a skip, and a stylesheet anew—
The rabbit approves, and so should you! 🐇✨

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

apps/homepage2/app/projects/projects.css

Oops! Something went wrong! :(

ESLint: 8.57.1

ESLint couldn't find the plugin "eslint-plugin-turbo".

(The package "eslint-plugin-turbo" was not found when loaded as a Node module from the directory "/apps/homepage2".)

It's likely that the plugin isn't installed correctly. Try reinstalling by running the following:

npm install eslint-plugin-turbo@latest --save-dev

The plugin "eslint-plugin-turbo" was referenced from the config file in "apps/homepage2/.eslintrc.js » @repo/eslint-config-custom » eslint-config-turbo".

If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team.

apps/homepage2/app/projects/page.js

Oops! Something went wrong! :(

ESLint: 8.57.1

ESLint couldn't find the plugin "eslint-plugin-turbo".

(The package "eslint-plugin-turbo" was not found when loaded as a Node module from the directory "/apps/homepage2".)

It's likely that the plugin isn't installed correctly. Try reinstalling by running the following:

npm install eslint-plugin-turbo@latest --save-dev

The plugin "eslint-plugin-turbo" was referenced from the config file in "apps/homepage2/.eslintrc.js » @repo/eslint-config-custom » eslint-config-turbo".

If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team.

Note

⚡️ AI Code Reviews for VS Code, Cursor, Windsurf

CodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback.
Learn more here.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@alwaysmeticulous
Copy link

🤖 No test run has been triggered as your Meticulous project has been deactivated (since you haven't viewed any test results in a while). Click here to reactivate.

Last updated for commit 2f060b9. This comment will update as new commits are pushed.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
apps/homepage2/app/projects/page.js (1)

169-169: Fix typo in language field.

There's a typo in the language field for the gatsby-portfolio project.

-      language: 'Javscript',
+      language: 'Javascript',
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5256276 and 2f060b9.

📒 Files selected for processing (2)
  • apps/homepage2/app/projects/page.js (13 hunks)
  • apps/homepage2/app/projects/projects.css (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: build
🔇 Additional comments (8)
apps/homepage2/app/projects/projects.css (1)

1-22: LGTM! Well-structured CSS refactoring.

The CSS classes are well-designed with appropriate flexbox layout, proper spacing, and thoughtful constraints for different content types. This refactoring improves maintainability by separating styling from inline styles in the JavaScript component.

apps/homepage2/app/projects/page.js (7)

8-8: LGTM! Proper CSS import added.

The CSS import correctly references the new stylesheet for the project styling classes.


39-39: Excellent consistency improvement!

The systematic update from "resume" to "résumé" throughout the project descriptions improves consistency and uses the proper French accent as intended. This aligns well with the professional presentation of the projects page.

Also applies to: 47-47, 55-55, 71-71, 79-79, 86-86, 253-253, 261-261, 269-269, 277-277, 293-293, 323-323, 346-346, 361-361, 376-376


401-405: Good categorization update.

The description update and category change from "images" to "tooling" for jsonresume-nix is more accurate, as it provides development tooling rather than image generation.


422-449: Well-formatted new project additions.

The four new projects are properly structured with all required fields (name, description, link, category, language) and are appropriately categorized. The new "theme" category for ResumeHub Theme and Straightforward Theme is a logical addition.


452-469: Good category organization improvements.

The alphabetical ordering and addition of new categories ("ats", "theme", "tooling") provides better organization for the growing list of community projects.


477-483: Successful refactoring to CSS classes.

The rendering function has been properly updated to use the new CSS classes (project-item, project-name, project-language, project-description) instead of inline styles, improving maintainability and consistency.


503-506: Good text improvements in footer.

The updates from "resumes" to "résumés" and "repo" to "repository" enhance the professional presentation and consistency with the rest of the page.

Comment on lines 415 to 421
{
name: 'resume-optimizer',
description: 'Use AI to ensure your resume passes ATS keyword screening.',
description: 'Use AI to ensure your résumé passes ATS keyword screening.',
link: 'https://github.com/panasenco/resume-optimizer',
category: 'images',
language: 'Nix',
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Verification agent

🧩 Analysis chain

Verify project categorization and language.

The "resume-optimizer" project appears to be miscategorized and has inconsistent metadata:

  • Description mentions "AI" and "ATS keyword screening" but category is "images"
  • Language is listed as "Nix" but the GitHub link suggests it's primarily Python-based

🏁 Script executed:

#!/bin/bash
# Description: Verify the resume-optimizer project details from its GitHub repository

# Check the repository to understand the primary language and purpose
curl -s https://api.github.com/repos/panasenco/resume-optimizer | jq '.language, .description, .topics'

# Check the repository files to understand the technology stack
curl -s https://api.github.com/repos/panasenco/resume-optimizer/languages | jq .

Length of output: 355


🏁 Script executed:

#!/bin/bash
# List unique project categories used in apps/homepage2/app/projects/page.js
rg "category: '.*'" -o apps/homepage2/app/projects/page.js | sed -E "s/.*category: '([^']+)'.*/\1/" | sort | uniq -c

Length of output: 389


Correct project categorization and language for resume-optimizer

Verified via GitHub API: the repo is primarily Python and centered on AI-powered résumé optimization. Please update the metadata accordingly.

• File: apps/homepage2/app/projects/page.js
Lines: 415–421

-    {
-      name: 'resume-optimizer',
-      description: 'Use AI to ensure your résumé passes ATS keyword screening.',
-      link: 'https://github.com/panasenco/resume-optimizer',
-      category: 'images',
-      language: 'Nix',
-    },
+    {
+      name: 'resume-optimizer',
+      description: 'Use AI to ensure your résumé passes ATS keyword screening.',
+      link: 'https://github.com/panasenco/resume-optimizer',
+      category: 'ai',
+      language: 'Python',
+    },
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
{
name: 'resume-optimizer',
description: 'Use AI to ensure your resume passes ATS keyword screening.',
description: 'Use AI to ensure your résumé passes ATS keyword screening.',
link: 'https://github.com/panasenco/resume-optimizer',
category: 'images',
language: 'Nix',
},
{
name: 'resume-optimizer',
description: 'Use AI to ensure your résumé passes ATS keyword screening.',
link: 'https://github.com/panasenco/resume-optimizer',
category: 'ai',
language: 'Python',
},
🤖 Prompt for AI Agents
In apps/homepage2/app/projects/page.js around lines 415 to 421, the
"resume-optimizer" project is incorrectly categorized as "images" and its
language is set to "Nix". Update the category to reflect its AI and résumé
optimization focus, such as "AI" or "productivity", and change the language to
"Python" to match the primary technology used in the GitHub repository.

@thomasdavis
Copy link
Member Author

PR Status: Needs Rebase

This PR is significantly out of sync with master (470 files changed, -24,855 lines) due to extensive refactoring work that's happened since May.

Suggested Action:

The new community projects and CSS refactoring in this PR are valuable, but need to be re-applied to the current codebase:

Option 1: Rebase the branch

git fetch origin master
git rebase origin/master
# Resolve conflicts

Option 2: Create a fresh PR

  1. Close this PR
  2. Cherry-pick the valuable changes onto a new branch from current master
  3. The new projects to add:
    • ResumeHub Theme
    • Astro JSON Resume
    • Lissy93 CV
    • Straightforward Theme
  4. CSS refactoring for projects page

Note: Some of these projects may have already been added in recent commits (checking projects page in master shows recent community additions).

Would you like me to create a fresh PR with just the new projects that aren't already in master?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant