php 7.1

Author: jsoumelidis

classes/Sap.php

@@ -26,7 +26,7 @@ public function __construct(array $logonParameters = null)
      * @throws InvalidArgumentException If empty array provided
      * @throws SapConnectionException   For invalid logon parameters or other error occured
      */
-    public function connect(array $logonParameters)
+    public function connect(array $logonParameters): void
     {
     }
 
@@ -78,7 +78,7 @@ public function call(string $function, array $args = null, bool $rtrim = null):
      *
      * @return void
      */
-    public function setFunctionClass(string $class)
+    public function setFunctionClass(string $class): void
     {
     }
 

php_sap.c

@@ -305,7 +305,7 @@ ZEND_END_ARG_INFO()
 
 PHP_METHOD(Sap, connect);
 
-ZEND_BEGIN_ARG_INFO(SAP_ME_ARGS(Sap, connect), 0)
+ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO(SAP_ME_ARGS(Sap, connect), IS_VOID, NULL, 0)
     ZEND_ARG_ARRAY_INFO(0, logonParameters, 0)
 ZEND_END_ARG_INFO()
 
@@ -317,7 +317,7 @@ ZEND_END_ARG_INFO()
 
 PHP_METHOD(Sap, setFunctionClass);
 
-ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO(SAP_ME_ARGS(Sap, setFunctionClass), IS_NULL, NULL, 1)
+ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO(SAP_ME_ARGS(Sap, setFunctionClass), IS_VOID, NULL, 0)
     ZEND_ARG_TYPE_INFO(0, className, IS_STRING, 0)
 ZEND_END_ARG_INFO()
 

tests/sap_005_sap_invoke_function_error.phpt

@@ -37,5 +37,5 @@ catch (TypeError $e) {
 Argument 1 passed to sap_invoke_function() must be of the type string, array given
 Argument 2 passed to sap_invoke_function() must be of the type resource, array given
 Argument 2 passed to sap_invoke_function() must be a resource of type SAP Connection
-Argument 3 passed to sap_invoke_function() must be of the type array, string given
-Argument 4 passed to sap_invoke_function() must be of the type boolean, array given
+Argument 3 passed to sap_invoke_function() must be of the type array or null, string given
+Argument 4 passed to sap_invoke_function() must be of the type boolean or null, array given

tests/sap_SapFunction___invoke_error.phpt

@@ -23,6 +23,6 @@ catch (LogicException $e) {
 }
 ?>
 --EXPECT--
-Argument 1 passed to SapFunction::__invoke() must be of the type array, string given
-Argument 2 passed to SapFunction::__invoke() must be of the type boolean, array given
+Argument 1 passed to SapFunction::__invoke() must be of the type array or null, string given
+Argument 2 passed to SapFunction::__invoke() must be of the type boolean or null, array given
 Function's description has not been fetched

tests/sap_SapRfcReadTable_select_error.phpt

@@ -81,10 +81,10 @@ Argument 1 passed to SapRfcReadTable::select() must not be an empty string
 Field names must be strings (integer detected)
 Argument 2 passed to SapRfcReadTable::select() must be of the type string, array given
 Argument 2 passed to SapRfcReadTable::select() must not be an empty string
-Argument 3 passed to SapRfcReadTable::select() must be of the type array, string given
-Argument 4 passed to SapRfcReadTable::select() must be of the type integer, array given
+Argument 3 passed to SapRfcReadTable::select() must be of the type array or null, string given
+Argument 4 passed to SapRfcReadTable::select() must be of the type integer or null, array given
 Argument 4 passed to SapRfcReadTable::select() must not be negative (-1)
-Argument 5 passed to SapRfcReadTable::select() must be of the type integer, array given
+Argument 5 passed to SapRfcReadTable::select() must be of the type integer or null, array given
 Argument 5 passed to SapRfcReadTable::select() must not be negative (-3)
-Argument 6 passed to SapRfcReadTable::select() must be of the type boolean, array given
+Argument 6 passed to SapRfcReadTable::select() must be of the type boolean or null, array given
 There is no connection to a SAP R/3 system

tests/sap_Sap___construct_error.phpt

@@ -9,4 +9,4 @@ catch (TypeError $e ) {
 }
 ?>
 --EXPECT--
-Argument 1 passed to Sap::__construct() must be of the type array, string given
+Argument 1 passed to Sap::__construct() must be of the type array or null, string given

tests/sap_Sap_call_error.phpt

@@ -30,6 +30,6 @@ catch (LogicException $e) {
 ?>
 --EXPECT--
 Argument 1 passed to Sap::call() must be of the type string, array given
-Argument 2 passed to Sap::call() must be of the type array, string given
-Argument 3 passed to Sap::call() must be of the type boolean, array given
+Argument 2 passed to Sap::call() must be of the type array or null, string given
+Argument 3 passed to Sap::call() must be of the type boolean or null, array given
 There is no connection to a SAP R/3 system