Skip to content

Use timeout when opening TCP socket and add source to FailedToConnect #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use timeout when opening TCP socket and add source to FailedToConnect #19

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions src/server.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@ pub enum ServerError {
#[error("error reading or writing data")]
ProtocolError,

#[error("failed to connect to server")]
FailedToConnect,
#[error("failed to connect to server: {source}")]
FailedToConnect { source: std::io::Error },

#[error("invalid JSON response: \"{0}\"")]
InvalidJson(String),
Expand Down Expand Up @@ -144,9 +144,11 @@ impl ConnectionConfig {

/// Connects to the server and consumes the builder.
pub async fn connect(self) -> Result<StatusConnection, ServerError> {
let stream = TcpStream::connect(format!("{}:{}", self.address, self.port))
.await
.map_err(|_| ServerError::FailedToConnect)?;
let Ok(stream) = tokio::time::timeout(self.timeout, TcpStream::connect(format!("{}:{}", self.address, self.port))).await else {
return Err(ServerError::FailedToConnect { source: std::io::ErrorKind::TimedOut.into()});
};

let stream = stream.map_err(|e| ServerError::FailedToConnect { source: e })?;

Ok(StatusConnection {
stream,
Expand Down