Skip to content

Conversation

andreww2012
Copy link

@andreww2012 andreww2012 commented Jul 14, 2025

Rule options schemas that use generateObjSchema utility allow extra properties to be passed in options object, which should not be allowed. This makes it easier for typos in rule options to go unnoticed.

This PR disallows extra properties in rules' schemas which currently allow them, and also fixes issues that arose after schemas strengthening.

@andreww2012 andreww2012 force-pushed the fix/disallow-extra-properties-in-rule-options branch from e94a52b to 15b6710 Compare July 14, 2025 13:08
@ljharb
Copy link
Member

ljharb commented Jul 14, 2025

This is a great change, but it's unfortunately semver-major.

@ljharb ljharb marked this pull request as draft July 14, 2025 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants