File: Add std::hash() template for juce::File #1583
+10
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was quite surprised to discover that I can't use
juce::Fileas a key instd::unordered_map. Obviously, the workaround is to just use a string with file's full path, but I believe it's an extra string allocation and copy, plus clutters the code, if you don't need that string for anything else. Also, it's possible to mix up relative and absolute paths by accident, which using the actual file object will help to avoid.I've laid it out in a similar manner to
juce::Stringandjuce::UUID, as they already havestd::hashimplementation. The actual hash function for 64-bit value was already there, so that's what I've used.Usage:
instead of: