Skip to content

Conversation

icweaver
Copy link

Closes #113

Uses fix suggested in JuliaLang/julia#53462 (comment)

One thing I notice is that the test ordering seems like it can change now:

Julia 1.11.6

Test Summary:           | Pass  Total  Time
Package                 |   12     12  0.3s
  test/runtests.jl      |    3      3  0.3s
    default_imports     |    1      1  0.2s
    TestSetup           |    2      2  0.0s
  src/TestItemRunner.jl |    9      9  0.0s
    compute_line_column |    9      9  0.0s
     Testing TestItemRunner tests passed

Julia 1.13.0--DEV.1109

Test Summary:           | Pass  Total  Time
Package                 |   12     12  0.6s
  src/TestItemRunner.jl |    9      9  0.5s
    compute_line_column |    9      9  0.5s
  test/runtests.jl      |    3      3  0.1s
    default_imports     |    1      1  0.0s
    TestSetup           |    2      2  0.0s
     Testing TestItemRunner tests passed

Not sure if that is a blocker, or if I am just holding it wrong?

Copy link

codecov bot commented Sep 10, 2025

Codecov Report

❌ Patch coverage is 82.60870% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.36%. Comparing base (9855a17) to head (35b874c).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/TestItemRunner.jl 82.60% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #114      +/-   ##
==========================================
- Coverage   93.07%   92.36%   -0.72%     
==========================================
  Files           2        2              
  Lines         130      131       +1     
==========================================
  Hits          121      121              
- Misses          9       10       +1     
Flag Coverage Δ
unittests 92.36% <82.60%> (-0.72%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@icweaver
Copy link
Author

icweaver commented Oct 1, 2025

Howdy all, just leaving a light ping here.

Would it also be helpful to add v1.12 and nightly to the jlpkgbutler-ci-master-workflow.yml and jlpkgbutler-ci-pr-workflow.yml workflows?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

LoadError: UndefVarError: push_testset not defined in Test (Julia 1.13+)

1 participant