Skip to content

Defer loading of widget implementation to first usage #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Defer loading of widget implementation to first usage #85

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1ebdcee
add lazy loading
bollwyvl Nov 21, 2020
138ea68
fix lint
bollwyvl Nov 21, 2020
c8f5514
Update {{cookiecutter.github_project_name}}/src/plugin.ts
bollwyvl Mar 17, 2021
dd70c70
lint
bollwyvl Mar 17, 2021
6f507d7
lint
bollwyvl Mar 17, 2021
5ace0eb
remove vanity chunk name and async, rely on returning the promise
bollwyvl Mar 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions {{cookiecutter.github_project_name}}/src/plugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@ import { Widget } from '@phosphor/widgets';

import { IJupyterWidgetRegistry } from '@jupyter-widgets/base';

import * as widgetExports from './widget';

import { MODULE_NAME, MODULE_VERSION } from './version';

const EXTENSION_ID = '{{ cookiecutter.npm_package_name }}:plugin';
Expand Down Expand Up @@ -37,6 +35,9 @@ function activateWidgetExtension(
registry.registerWidget({
name: MODULE_NAME,
version: MODULE_VERSION,
exports: widgetExports,
exports: async () => import(
/* webpackChunkName: "{{ cookiecutter.npm_package_name }}" */
'./widget'
),
});
}
2 changes: 1 addition & 1 deletion {{cookiecutter.github_project_name}}/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"declaration": true,
"esModuleInterop":true,
"lib": ["es2015", "dom"],
"module": "commonjs",
"module": "esnext",
"moduleResolution": "node",
"noEmitOnError": true,
"noUnusedLocals": true,
Expand Down