-
Notifications
You must be signed in to change notification settings - Fork 2
[DNM] Module 2 exercise B: "Hello, world" widget launched from the command palette #29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If some participants are ahead, they may want to do some cleanup
The 1.2.x version is the more popular Google result, sadly.
Object shorthand syntax will be new to non-javascript developers. It's an unnecessary concept for us to introduce in this tutorial.
ktaletsk
reviewed
Oct 21, 2025
ktaletsk
reviewed
Oct 21, 2025
jasongrout
reviewed
Oct 21, 2025
ktaletsk
approved these changes
Oct 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks great!
Co-authored-by: Konstantin Taletskiy <[email protected]>
Co-authored-by: Jason Grout <[email protected]>
|
Thanks for the useful reviews, all! I'm working through it :) |
Co-authored-by: Konstantin Taletskiy <[email protected]>
1d93bef to
3a16244
Compare
Co-authored-by: Konstantin Taletskiy <[email protected]>
e07ec5a to
60208ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔍 Preview: https://jupytercon2025-developingextensions--29.org.readthedocs.build/
Note: This Pull Request preview is provided by ReadTheDocs. Our production website, however, is currently deployed with GitHub Pages.