Run black at pre-commit time
#311
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfisher87
commented
Aug 27, 2025
| rev: "v4.0.0-alpha.8" # Use the sha / tag you want to point at | ||
| hooks: | ||
| - id: prettier | ||
| types_or: [css, javascript, yaml] |
There was a problem hiding this comment.
Happy to remove or move this to a separate PR, I was trying to avoid chained PRs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My PR #309 passed pre-commit checks, but failed when GitHub Actions ran
black --check. Runningblackat pre-commit time is a bit less frictiony :)I considered using Ruff for formatting, but Ruff and Black have, I believe, diverged slightly. I think switching CI + pre-commit to both use Ruff for formatting would be better done in a separate PR.