Clickhouse SPIFFE MTLs and SQL over HTTPS support #161
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖 Generated body based on the diff 😁
Summary
This merge request addresses a critical ClickHouse URL corruption bug that occurred during connection retries and introduces several improvements to database connection handling, including context support with timeouts.
Bug Fix
connectClickHouse()was mutating the connection struct'sdriverfielddial tcp: lookup clickhouse+https: no such hostConnection Handling Improvements
Ping()calls with context-awarePingContext(ctx)TLS Configuration Enhancements
MTLSSetupinterface for dependency injectionTLSConfigResultstructure to encapsulate TLS configuration resultsconfigureClickHouseTLS()connectClickHouse()Testing Improvements
TestURLParameterRemovalUnit)Compatibility
Testing
go build .Configuration Example
Users can now configure timeouts in their job YAML: