Fix #100 allowing to tail named pipes #101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`hpcloud/tail` supports tailing named pipe if we tell it to do so. This patch detects if the tailed file is a named pipe and configure `hpcloud/tail` accordingly. Note that it probably works only on Unix. Signed-off-by: Brice Figureau <[email protected]>
|
In retrospect this patch is not enough to successfully tail named pipe :( |
|
Is there an updated needed for |
|
Hi @jwilder, This patch works AFAIK, but I had some stability issues with inotify and named pipes that are not related to It's up to you to decide if you want to merge the change or not. Anyway, thanks for dockerize, it's a very useful tool! |
jwilder
approved these changes
Mar 20, 2018
|
@masterzen Thanks. It looks pretty harmless to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As seen in #100, it is impossible to tail a named pipe. This adds the necessary code to configure
hpcloud/tailwhen the tailed file is a fifo.