Update nvidia runtime setup info (gpu-operator Helm chart) #6566
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnummelin
reviewed
Nov 6, 2025
Comment on lines
+216
to
+217
| --set "toolkit.env[0].name=CONTAINERD_CONFIG" \ | ||
| --set "toolkit.env[0].value=/run/k0s/containerd-cri.toml" \ |
Member
There was a problem hiding this comment.
I wonder if these should point to the "real" containerd config instead of this k0s managed CRI merged one 🤔 I guess it boils down to what exactly the operator does with this.
This is what the docs say:
CONTAINERD_CONFIG
The path on the host to the top-level containerd config file. By default this will point to /etc/containerd/containerd.toml (the default location for containerd). It should be customized if your containerd installation is not in the default location.
Based on the above, I'd say this should point to /etc/k0s/containerd.toml which in turn imports the CRI config
Author
There was a problem hiding this comment.
I just tried the config and it worked out-of-the box.
Contributor
|
Could you please sign off the commit? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use up-to-date NVidia GPU operator Helm chart installation - updated parameters. Previous version doesn't work anymore as the chart was updated and the command didn't use
--versionparameter.Link: https://docs.k0sproject.io/head/runtime/#using-nvidia-container-runtime