[Backport release-1.34] Fix internal/http/TestDownload_CancelDownload #6713
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test's server handler used to loop on writes. Once the client canceled the download, the next write hit a broken pipe and failed the test intermittently: - The handler kept looping: write chunk, check request context, short sleep, repeat. - When the test client canceled, the HTTP stack closed the TCP connection immediately. - The handler only noticed cancellation after the select ran, but there was a race between the next write and the select. - If Go scheduled the loop so that it hit another write before the select observed the request context being done, that write ran against a half-closed socket and returned broken pipe. The handler now writes once, flushes to let the client see the written data, waits for the request context being done, and asserts that the request context was canceled, hence it will never write more than once. Fixes: 1a54f6c ("Implement cancellation of stale downloads") Signed-off-by: Tom Wieczorek <[email protected]> (cherry picked from commit c6577d7)
16 tasks
twz123
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automated backport to
release-1.34, triggered by a label in #6630.See .