Skip to content

Conversation

omer-tmakers
Copy link

What

Upgrade Keda and GPU components versions

Why

To have the latest working version of K3D using GPU

Implications

@iwilltry42 iwilltry42 requested a review from Copilot September 22, 2025 20:58
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Upgrades GPU components and Keda versions to provide better CUDA support in k3d with latest working versions.

  • Updates K3s version from v1.28.8-k3s1 to v1.31.7-k3s1
  • Upgrades CUDA base image from 12.4.1-base-ubuntu22.04 to 12.8.1-base-ubuntu24.04
  • Updates NVIDIA device plugin from v0.15.0-rc.2 to v0.17.1

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
install_gpu_drivers_server.sh New script for installing GPU drivers on Ubuntu 24.04 server
device-plugin-daemonset.yaml Updates NVIDIA device plugin image version
build.sh Enhanced build script with improved error handling and updated versions
Dockerfile Multi-stage Dockerfile improvements with updated CUDA/K3s versions
cuda.md Documentation updates reflecting new versions and server preparation

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment on lines +37 to +53
# Add NVIDIA GPG key
curl -s -L https://nvidia.github.io/libnvidia-container/gpgkey | \
sudo gpg --dearmor -o /usr/share/keyrings/nvidia-container-toolkit-keyring.gpg

# Add repo using fake distribution
curl -s -L https://nvidia.github.io/libnvidia-container/$distribution/libnvidia-container.list | \
sed 's#deb https://#deb [signed-by=/usr/share/keyrings/nvidia-container-toolkit-keyring.gpg] https://#g' | \
sudo tee /etc/apt/sources.list.d/nvidia-container-toolkit.list


sudo apt-get update
sudo apt-get install -y nvidia-container-toolkit

sudo nvidia-ctk runtime configure --runtime=docker

sudo systemctl restart docker

Copy link
Preview

Copilot AI Sep 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code block duplicates the NVIDIA toolkit installation steps that already appear earlier in the script (lines 17-33). The duplicated code should be removed to avoid confusion and potential conflicts.

Suggested change
# Add NVIDIA GPG key
curl -s -L https://nvidia.github.io/libnvidia-container/gpgkey | \
sudo gpg --dearmor -o /usr/share/keyrings/nvidia-container-toolkit-keyring.gpg
# Add repo using fake distribution
curl -s -L https://nvidia.github.io/libnvidia-container/$distribution/libnvidia-container.list | \
sed 's#deb https://#deb [signed-by=/usr/share/keyrings/nvidia-container-toolkit-keyring.gpg] https://#g' | \
sudo tee /etc/apt/sources.list.d/nvidia-container-toolkit.list
sudo apt-get update
sudo apt-get install -y nvidia-container-toolkit
sudo nvidia-ctk runtime configure --runtime=docker
sudo systemctl restart docker

Copilot uses AI. Check for mistakes.

The K3s container itself also needs to run with this runtime.
If you are using Docker you can install the [NVIDIA Container Toolkit](https://docs.nvidia.com/datacenter/cloud-native/container-toolkit/install-guide.html).

## Preparing Server to run Keda
Copy link
Preview

Copilot AI Sep 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The heading mentions 'Keda' but should be 'CUDA' based on the context. This appears to be a typo as the section is about preparing a server for GPU/CUDA workloads, not Keda (Kubernetes Event-driven Autoscaling).

Suggested change
## Preparing Server to run Keda
## Preparing Server to run CUDA

Copilot uses AI. Check for mistakes.


## Preparing Server to run Keda

To Create a Server that has all the drivers installed you can use exmaple script prepared for Ubuntu 24.04
Copy link
Preview

Copilot AI Sep 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a typo in 'exmaple' which should be 'example'.

Suggested change
To Create a Server that has all the drivers installed you can use exmaple script prepared for Ubuntu 24.04
To Create a Server that has all the drivers installed you can use example script prepared for Ubuntu 24.04

Copilot uses AI. Check for mistakes.

ca-certificates \
software-properties-common \
lsb-release \
less \
Copy link
Preview

Copilot AI Sep 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 'less' package is listed twice in the same RUN command (lines 26 and 30), creating unnecessary duplication.

Suggested change
less \

Copilot uses AI. Check for mistakes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant