Allow pulling images from private registries #1598
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Make use of the auth present in the default Docker config to pull images allowing K3d to pull images from private registries that have been previously authenticated with the
docker login
.Why
K3d uses the docker SDK to pull images which doesn't use the stored registry auth credentials like the Docker cli does. If for example, you have to use a private registry as a proxy for pulling images like the K3s image or you want to have your own k3s image for some reason on a private registry, K3d will not be able to pull them as there's no way to authenticate. A possible workaround would be to pull the image before creating a cluster.
Implications
I don't think this introduces any breaking changes whatsoever. All the existing behaviour should remain the same.