feat: add flexible parameter override system with JSON configuration #66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add support for overriding claudeHash, claudeVersion, and claudeUrl via JSON input - Consolidate parameters into single claude-params input file - Maintain single source of truth for defaults in package definition - Support fallback to defaults when no parameters provided - Enable easy local customization without upstream dependency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, first of all, thanks for this claude-desktop flake!
The reoccurring hash mismatch problems, made me implement a workaround, where i can define the claude version, executable url and hash locally. Maybe this could help to minimize some repeating issues here in this project?
I implemented the latest solution from this issue here: NixOS/nix#5663
Changes to the local claude-params file will be tracked in flake.lock, and mark the flake as dirty when changed.
If this is useful for this project, i could also update the Documentation. If not, just discard the Pull-Request.