NATS Driver Conformance Updates

[samuelattwood]

• Brings NATS Backend up-to-date
• Resolves issues with Kubernetes Conformance test suite
• Adds read-after-write checks
• Various fixes and enhancements

[brandond]

This is great to see! Don't forget to --signoff your commits for DCO.

[brandond]

Please uncomment the core apiserver tests to validate that those pass as well:

kine/scripts/test-run-nats

Lines 10 to 11 in 1d571b0

	### Disabled until NATS is validated to pass tests
	# KINE_IMAGE=$IMAGE KINE_ENDPOINT="nats://$ip:$port?noEmbed" GO_TEST_EXTRAFLAGS="-tags nats" run-apiserver-tests

[DeanKamali]

Any update on this? @samuelattwood

I have some time to dedicate for this, let me know if I can do any reviews or pick up any blockers.

[samuelattwood]

There is a small fix I had to make after enabling the apiserver tests that wasn't caught by the Sonobuoy conformance suite.

I have been at KubeCon this week but I will have that up tomorrow or Monday, in addition to some improvements regarding tombstones.

[brandond]

No, don't do your own signal handling. This is handled by the CLI or calling application:

• kine/pkg/app/app.go

  Line 225 in 1d571b0

  ctx := signals.SetupSignalContext()

• kine/pkg/signals/signal.go

  Lines 34 to 37 in 1d571b0

  	// SetupSignalContext is same as SetupSignalHandler, but a context.Context is returned.
  	// Only one of SetupSignalContext and SetupSignalHandler should be called, and only can
  	// be called once.
  	func SetupSignalContext() context.Context {

You should be using the context and waitGroup that you are provided - call wg.Add(1) when starting, do what you're going to do until the context is done, and then call wg.Done() when you've shut down.