-
-
Notifications
You must be signed in to change notification settings - Fork 151
Infra: Create dedicated Dependabot group for Spring dependencies #1181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
8063e09
to
caff098
Compare
Yeah, so the idea why I've grouped all (!) the dependency bumps in a single group is to reduce dependabot's PR spam. I thought we would've excluded the dependencies causing build/test failures from this chonky PRs, but neither we had much time addressing single-dependency PRs before, nor we do have for this chonks now. I agree with the approach overall, let's start creating some dedicated groups. |
Thank you for the explanation. I understand that dependabot pull requests can overwhelm the maintainers for such a large project like this. Let's start small with two groups for now and we can iterate as we see fit Thank you again! |
6aa1e6f
to
437e8ce
Compare
@Haarolean What blocks merging this one? I have at least 2 follow up PRs planned after this one Thanks again! |
What changes did you make? (Give an overview)
While Dependabot's grouped updates can be convenient, they should be used with care, particularly in projects with a large number of dependencies like this one.
Grouped updates often combine changes that are not compatible with each other, which can make upgrades more difficult and increase the risk of breaking the build. For instance, #1163 includes over 20 updates, and it's not surprising that the build is currently failing. Reviewing and validating that many changes at once is a significant challenge.
This pull request takes an initial step toward organizing updates into smaller, more focused groups, beginning with Spring . Spring was selected because it is both a common source of security advisories and a foundational component of the project’s that should be updated regularly.
Ultimately, we are using grouped dependencies for convenience, but it should not cause us to miss critical upgrades due to the nature and complexity of the groups as the project's complexity grows
How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)
It created this pull request: https://github.com/yeikel/kafka-ui/pull/197/files
Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)
A picture of a cute animal (not mandatory but encouraged)