Skip to content

Conversation

@pandeysambhi
Copy link
Contributor

@pandeysambhi pandeysambhi commented Aug 11, 2025

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)
Considered context path for auth log out. fixes #1248
Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

@pandeysambhi pandeysambhi requested a review from a team as a code owner August 11, 2025 18:40
@kapybro kapybro bot added status/triage Issues pending maintainers triage status/triage/manual Manual triage in progress status/triage/completed Automatic triage completed and removed status/triage Issues pending maintainers triage labels Aug 11, 2025
@Haarolean Haarolean added scope/frontend Related to frontend changes type/bug Something isn't working area/auth App authentication related issues and removed status/triage/manual Manual triage in progress labels Aug 12, 2025
@Haarolean Haarolean changed the title FE: fixes(#1248): context path for logout FE: Fix context path for logout Aug 12, 2025
@Haarolean Haarolean added this to the 1.4 milestone Aug 15, 2025
@Haarolean Haarolean changed the title FE: Fix context path for logout FE: Auth: Fix context path for logout Aug 15, 2025
@Haarolean Haarolean enabled auto-merge (squash) August 15, 2025 10:26
@Haarolean
Copy link
Member

@pandeysambhi thanks for your first PR! This will be merged once CI passes.

@Haarolean Haarolean merged commit d542c46 into kafbat:main Aug 15, 2025
16 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in Release 1.4 Aug 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/auth App authentication related issues scope/frontend Related to frontend changes status/triage/completed Automatic triage completed type/bug Something isn't working

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

FE: Auth: Logout button should consider context path

3 participants