Skip to content

Conversation

tub
Copy link
Contributor

@tub tub commented Sep 10, 2025

We don't need to hide the compare versions button in readOnly as comparing versions isn't a mutation.

Closes #1324

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)

Moves the Compare Versions button outside of isReadOnly

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Manual test verification:

image

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

We don't need to hide the compare versions button in readOnly
as comparing versions isn't a mutation.
@kapybro kapybro bot added status/triage Issues pending maintainers triage status/triage/manual Manual triage in progress status/triage/completed Automatic triage completed and removed status/triage Issues pending maintainers triage labels Sep 10, 2025
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi tub! 👋

Welcome, and thank you for opening your first PR in the repo!

Please wait for triaging by our maintainers.

Please take a look at our contributing guide.

@Haarolean Haarolean added scope/frontend Related to frontend changes type/bug Something isn't working area/ux User experiense issues and removed status/triage/manual Manual triage in progress labels Sep 10, 2025
@tub tub marked this pull request as ready for review September 11, 2025 10:39
@tub tub requested a review from a team as a code owner September 11, 2025 10:39
@germanosin germanosin changed the title Expose the Compare Versions button always FE: Expose the Compare Versions button always Sep 12, 2025
@germanosin germanosin merged commit 58c361f into kafbat:main Sep 12, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ux User experiense issues scope/frontend Related to frontend changes status/triage/completed Automatic triage completed type/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FE: UX: SR "Compare Versions" button is hidden w/ r/o cluster
3 participants