Skip to content

Conversation

@Haarolean
Copy link
Member

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)

Nuked configured logback config.

  1. No idea why we had one in the first place, the log message doesn't differ much:
    before:
    2025-10-31 22:38:50,017 INFO [kafka-admin-client-thread | kafbat-ui-admin-1761925126-1] o.a.k.c.NetworkClient: [AdminClient clientId=kafbat-ui-admin-1761925126-1] Node -1 disconnected.
    after:
    2025-10-31T22:39:26.466+07:00 INFO 94452 --- [in-1761925163-1] org.apache.kafka.clients.NetworkClient : [AdminClient clientId=kafbat-ui-admin-1761925163-1] Node -1 disconnected.
  2. Removing one allows spring boot to use default integration mechanisms and overrides via env vars, see Support JSON Logging capability #1171

Fixes #1171

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

@Haarolean Haarolean added this to the 1.4 milestone Oct 31, 2025
@Haarolean Haarolean requested a review from germanosin October 31, 2025 15:44
@Haarolean Haarolean self-assigned this Oct 31, 2025
@Haarolean Haarolean requested a review from a team as a code owner October 31, 2025 15:44
@Haarolean Haarolean added type/enhancement En enhancement/improvement to an already existing feature scope/backend Related to backend changes labels Oct 31, 2025
@kapybro kapybro bot added the status/triage Issues pending maintainers triage label Oct 31, 2025
@kapybro kapybro bot added status/triage/completed Automatic triage completed and removed status/triage Issues pending maintainers triage labels Oct 31, 2025
@Haarolean Haarolean added the hacktoberfest-accepted PRs accepted towards hacktoberfest goal and will be counted as approved label Oct 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hacktoberfest-accepted PRs accepted towards hacktoberfest goal and will be counted as approved scope/backend Related to backend changes status/triage/completed Automatic triage completed type/enhancement En enhancement/improvement to an already existing feature

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

Support JSON Logging capability

2 participants