Skip to content

Serde: Enable header serialization #509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jul 24, 2025
Merged

Serde: Enable header serialization #509

merged 8 commits into from
Jul 24, 2025

Conversation

MDzaja
Copy link
Contributor

@MDzaja MDzaja commented Jul 29, 2024 •
edited by germanosin
Loading

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)
Closes #346.
Extends io.kafbat.ui.serde.api.Serde.Serializer to support message headers editing by custom serializers.

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
    A custom serializer was developed, and the feature was tested with it.
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)
maki (4)

@MDzaja MDzaja requested a review from a team as a code owner July 29, 2024 20:56
@kapybro kapybro bot added status/triage Issues pending maintainers triage status/triage/manual Manual triage in progress status/triage/completed Automatic triage completed and removed status/triage Issues pending maintainers triage labels Jul 29, 2024
github-actions[bot]
github-actions bot reviewed Jul 29, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi MDzaja! 👋

Welcome, and thank you for opening your first PR in the repo!

Please wait for triaging by our maintainers.

Please take a look at our contributing guide.

@MDzaja MDzaja changed the title Feature/issue#346 Serde: Enable header modifications by custom serializer Jul 29, 2024
@Haarolean Haarolean requested review from iliax and germanosin August 10, 2024 15:07
@Haarolean Haarolean added type/enhancement En enhancement/improvement to an already existing feature scope/backend Related to backend changes area/serde Serialization & Deserialization (plugins) and removed status/triage/manual Manual triage in progress labels Sep 24, 2024
@Haarolean Haarolean added the hacktoberfest-accepted PRs accepted towards hacktoberfest goal and will be counted as approved label Oct 4, 2024
Haarolean
Haarolean requested changes Dec 18, 2024
View reviewed changes
@kapybro Kapybro
Copy link

kapybro bot commented Dec 31, 2024

Further user feedback is requested. Please reply within 7 days or we might close the issue.

@kapybro kapybro bot assigned MDzaja Dec 31, 2024
@kapybro Kapybro
Copy link

kapybro bot commented Jan 7, 2025

No feedback received within 7 days. Auto closing.

@kapybro kapybro bot closed this Jan 7, 2025
@Haarolean Haarolean reopened this Jan 7, 2025
@marcosschroh
Copy link

marcosschroh commented Apr 17, 2025 •
edited
Loading

Is there any news of this @MDzaja ? We are facing a similar problem. We want serialize the value according to some headers values.

@Haarolean
Copy link
Member

Is there any news of this @MDzaja ? We are facing a similar problem. We want serialize the value according to some headers values.

we'll take a look, thanks for bumping

@marcosschroh
Copy link

Hi, Is there anything that we can do to help you with this feature?

@germanosin germanosin self-assigned this Jun 11, 2025
@germanosin germanosin added this to the 1.3 milestone Jun 11, 2025
@Haarolean Haarolean removed this from Release 1.3 Jul 11, 2025
@Haarolean Haarolean modified the milestones: 1.3, 1.4 Jul 11, 2025
@Haarolean Haarolean moved this from Active to Revisit in Housekeeping Jul 13, 2025
@germanosin
Merge remote-tracking branch 'origin/main' into fork/MDzaja/feature/i…
ce901bd 
…ssue#346

# Conflicts:
#	api/src/main/java/io/kafbat/ui/serdes/ProducerRecordCreator.java
#	serde-api/pom.xml
@germanosin
Switched to anonymous class
a4fae86
@Haarolean Haarolean self-requested a review July 23, 2025 09:11
@Haarolean Haarolean assigned Haarolean and unassigned germanosin Jul 23, 2025
@Haarolean Haarolean removed this from Housekeeping Jul 23, 2025
@Haarolean Haarolean removed the request for review from iliax July 23, 2025 09:14
@Haarolean Haarolean moved this to Todo in Release 1.4 Jul 24, 2025
@Haarolean Haarolean moved this from Todo to In Development in Release 1.4 Jul 24, 2025
@Haarolean Haarolean merged commit 5079b00 into kafbat:main Jul 24, 2025
15 checks passed
@github-project-automation github-project-automation bot moved this from In Development to Done in Release 1.4 Jul 24, 2025
@Haarolean Haarolean changed the title Serde: Enable header modifications by custom serializer Serde: Enable header serialization Jul 24, 2025
@Haarolean Haarolean removed their assignment Jul 24, 2025
@Haarolean
Copy link
Member

@MDzaja Thanks for your first contribution to kafbat ui! Sorry it took this long

@marcosschroh
Copy link

Are you going to release this feature in https://central.sonatype.com/artifact/io.kafbat.ui/serde-api?

@Haarolean Haarolean mentioned this pull request Aug 5, 2025
Open
@Haarolean
Copy link
Member

@marcosschroh #1243

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Haarolean Haarolean Haarolean approved these changes

@github-actions github-actions[bot] github-actions[bot] left review comments

@germanosin germanosin germanosin approved these changes

Assignees

@MDzaja MDzaja

Labels
area/serde Serialization & Deserialization (plugins) hacktoberfest-accepted PRs accepted towards hacktoberfest goal and will be counted as approved scope/backend Related to backend changes status/triage/completed Automatic triage completed type/enhancement En enhancement/improvement to an already existing feature
Projects
Release 1.4
Status: Done
Milestone
1.4
Development

Successfully merging this pull request may close these issues.

Serde: Enable header modifications by custom serializer
4 participants
@MDzaja @marcosschroh @Haarolean @germanosin