Skip to content

Conversation

@ngbrown
Copy link
Collaborator

@ngbrown ngbrown commented Apr 7, 2023

This replaces #17

All projects were updated to SDK style projects.

Updating to YaccLexTools version 1.0.0 enabled building in SDK style projects. It also changed the exposed QUT.GplexBuffers classes. This may be considered an API break, or it may be ignored. Right now I set the version to 2.0.0.

Also different from the other pull request, is that this enables multi-targeting, so the NuGet package will have multiple versions of the DLL for different runtimes.

The GitHub actions were all updated to the most recent versions and caching was added. I also set the version of the DLL within the build step.

@ngbrown ngbrown force-pushed the new-netstandard2 branch from 8dc2152 to b155592 Compare April 7, 2023 08:32
@ngbrown ngbrown force-pushed the new-netstandard2 branch from b155592 to f12ed94 Compare April 7, 2023 08:56
@ngbrown
Copy link
Collaborator Author

ngbrown commented Apr 7, 2023

The part of the check that is failing is this action to release on latest:

- uses: "marvinpinto/action-automatic-releases@latest"
with:
repo_token: "${{ secrets.GITHUB_TOKEN }}"
automatic_release_tag: "latest"
prerelease: true
title: "Development Build"
files: |
out/*
README.md
LICENSE

I don't know what the goal of this step was, but it seems like re-releasing on the same tag repeatedly doesn't work. Also, it doesn't seem like a good idea to do this within pull requests. It should only be done on commits to master.

@kallemooo
Copy link
Owner

kallemooo commented Apr 16, 2023

The part of the check that is failing is this action to release on latest:

- uses: "marvinpinto/action-automatic-releases@latest"
with:
repo_token: "${{ secrets.GITHUB_TOKEN }}"
automatic_release_tag: "latest"
prerelease: true
title: "Development Build"
files: |
out/*
README.md
LICENSE

I don't know what the goal of this step was, but it seems like re-releasing on the same tag repeatedly doesn't work. Also, it doesn't seem like a good idea to do this within pull requests. It should only be done on commits to master.

The idea is to have a "latest beta-release" automatically created. But it should only be done on master...
So the rule should be updated to not include branches.
Or removed as it seems not to work properly, and the github repo have not been updated the latest two years.
Should probably be replaced with an action based on softprops/action-gh-release

@sven-n
Copy link

sven-n commented May 8, 2024

Hi, any news here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants