Rename property of AXIS_PTS to use it in VB.Net #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add instanciation of property alignements of class RECORD_LAYOUT
Owner
|
Hi, Thanks for the pull request. The changes do not pass the tests, so please look in to the comments and solve the problems. /Karl |
kallemooo
reviewed
Jun 11, 2019
| $$ = $1; | ||
| $$.guard_rails = new GUARD_RAILS(@2); | ||
| } | ||
| | axis_pts_data if_data { |
Owner
There was a problem hiding this comment.
This change is not correct.
if_data must be based on axis_pts_data
| $$ = $1; | ||
| $$.symbol_link = $2; | ||
| } | ||
| | axis_pts_data if_data { |
| public CALIBRATION_ACCESS calibration_access; | ||
|
|
||
| [Element(12)] | ||
| public DEPOSIT deposit; |
Owner
There was a problem hiding this comment.
This do not work if not the corresponding usages is updated.
Line 472 in asap2.language.grammar.y must be updated also.
| <RootNamespace>Asap2</RootNamespace> | ||
| <AssemblyName>Asap2</AssemblyName> | ||
| <TargetFrameworkVersion>v4.5</TargetFrameworkVersion> | ||
| <TargetFrameworkVersion>v4.0</TargetFrameworkVersion> |
Owner
There was a problem hiding this comment.
Is a downgrade of framework version really needed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename property of AXIS_PTS to use it in VB.Net
Add instanciation of property alignements of class RECORD_LAYOUT