Generate electorate updates #430
Open
+122
−77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
An example of how to run the updated script: |
stevenhorsman
force-pushed
the
generate-electorate-updates
branch
2 times, most recently
from
0a0a1b4 to
dd02bc0
Compare
- Update the list to skip some archived projects and the github security advisory repos to save time - Remove some repos we no longer have - Sort the list so it's easier to compare Signed-off-by: stevenhorsman <[email protected]>
We no longer use stable branches, and topic branches shouldn't be considered, so only get commits from the default branch (`main` currently) Signed-off-by: stevenhorsman <[email protected]>
We are currently considering the merge commit as a code contribution, so fix this Signed-off-by: stevenhorsman <[email protected]>
Updates to mean the user doesn't need to edit code to customise the script, but instead: - Read the github token from an env - Accept the end and (optional) start dates to use in the commit scans Update the python file to have functions and a `main` method Signed-off-by: stevenhorsman <[email protected]>
stevenhorsman
force-pushed
the
generate-electorate-updates
branch
from
dd02bc0 to
08d2d0d
Compare
We have some users (maybe as they have changed email, or don't have a public email on github), that we can't find gh logins for, so we've just used the email, but this could result in us double counting emails in the electorate list, so instead provide a mapping of these problematic emails to the correct github username and add warning messages to let users know to keep these up-to-date. Signed-off-by: stevenhorsman <[email protected]>
stevenhorsman
force-pushed
the
generate-electorate-updates
branch
from
08d2d0d to
c223719
Compare
|
Thank you! We've just been chatting about this PR. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various updates to the generate_electorate python script to fix a few bugs, update it to make processing much quicker, give a more consistent output and make it easier to run.