-
Notifications
You must be signed in to change notification settings - Fork 7
dashboard: Fetch data whenever a PR is merged into main #24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I thought of doing this but decided against it: we risk needlessly going over the GH rate limit in case we merge a bunch of PRs that don't affect the data schema. But, can we implement this in a way that it only triggers the workflow if the fetching script is modified? If we do that, do you see any potential issue with that approach? |
Also if you decide to pursue this PR, please only keep the commit that's relevant to the title, so we minimize the PR size. |
1d6f5b9
to
bbf376c
Compare
Should be implemented with your suggested changes. |
bbf376c
to
f3c6cde
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One quick change!
Added a trigger to fetch the data again on changes to the fetch script/yaml. Fixes kata-containers#7 Signed-off-by: Anna Finn <[email protected]>
a213518
to
62482df
Compare
We accidentally broke the workflow in #24 so this fixes that. Signed-off-by: Aurélien Bombo <[email protected]>
We accidentally broke the workflow in #24 so this fixes that. Signed-off-by: Aurélien Bombo <[email protected]>
MUST:
Context:
If we merge a PR to main that assumes that new data is required (e.g. the PR runs view feature), the website will be updated immediately, but the data will take up to 24 hours to refresh. However, we need the new data.
Solution:
On any push to the main branch that updates "scripts/fetch-ci-data-nightly.js", the fetch workflow will be triggered (includes merges).
ADDITIONAL:
Since the Nightly tests are only run nightly, we only need to fetch the script once a day.
The PR data changes whenever a PR is made, so we could add:
This will fetch data whenever a new PR is made (might need to set a delay to let tests finish)