Skip to content

Conversation

afinn12
Copy link
Contributor

@afinn12 afinn12 commented Nov 6, 2024

MUST:

  • Add token to Github secrets to increase rate limits for fetch scripts
  • Confirm whether to track the .yaml script for the fetch workflow
    • And whether to keep the commented out PR fetch script as a note

Context:
If we merge a PR to main that assumes that new data is required (e.g. the PR runs view feature), the website will be updated immediately, but the data will take up to 24 hours to refresh. However, we need the new data.

Solution:
On any push to the main branch that updates "scripts/fetch-ci-data-nightly.js", the fetch workflow will be triggered (includes merges).

ADDITIONAL:
Since the Nightly tests are only run nightly, we only need to fetch the script once a day.
The PR data changes whenever a PR is made, so we could add:

  pull_request:
    branches:
      - main

This will fetch data whenever a new PR is made (might need to set a delay to let tests finish)

@afinn12 afinn12 mentioned this pull request Nov 6, 2024
6 tasks
@sprt
Copy link
Contributor

sprt commented Nov 6, 2024

I thought of doing this but decided against it: we risk needlessly going over the GH rate limit in case we merge a bunch of PRs that don't affect the data schema.

But, can we implement this in a way that it only triggers the workflow if the fetching script is modified? If we do that, do you see any potential issue with that approach?

@sprt
Copy link
Contributor

sprt commented Nov 6, 2024

Also if you decide to pursue this PR, please only keep the commit that's relevant to the title, so we minimize the PR size.

@afinn12
Copy link
Contributor Author

afinn12 commented Nov 6, 2024

Should be implemented with your suggested changes.

Copy link
Contributor

@a1icja a1icja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One quick change!

@sprt
Copy link
Contributor

sprt commented Nov 6, 2024

@afinn12 Can you fix the commit message check and also include "Fixes: #7" in your commit message so the issue is automatically closed?

Added a trigger to fetch the data again on changes to the fetch script/yaml.

Fixes kata-containers#7

Signed-off-by: Anna Finn <[email protected]>
@sprt sprt merged commit 1bee0cd into kata-containers:main Nov 7, 2024
1 check passed
sprt added a commit that referenced this pull request Nov 7, 2024
We accidentally broke the workflow in #24 so this
fixes that.

Signed-off-by: Aurélien Bombo <[email protected]>
sprt added a commit that referenced this pull request Nov 7, 2024
We accidentally broke the workflow in #24 so this fixes that.

Signed-off-by: Aurélien Bombo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants