Skip to content

Conversation

sprt
Copy link
Contributor

@sprt sprt commented Nov 7, 2024

It seems like I broke the build in #19 so this reverts that.

See deployment failure after #19:

https://github.com/kata-containers/kata-containers.github.io/actions/runs/11725178574

@sprt sprt changed the title Revert "dashboard: Add <title> tag" dashboard: Unbreak npm build Nov 7, 2024
@afinn12
Copy link
Contributor

afinn12 commented Nov 7, 2024

Error:

image

Suggestion

This was replicated by running npm run build and npm start:
image
(good to test before merging)

To solve,

import { Head } from "next/head";

must be changed to:

import Head from "next/head";

You could also exclude Head. In our repo, we've successfully been deploying without it:


  return (
    <>
      
      <title>Kata CI Dashboard</title>

I broke the build in #19 so this fixes that.

Turns out Copilot had originally generated a correct import statement (without
brackets), but I didn't trust it because it looked inconsistent with the
others, so I modified it. All hail our new AI overlords.

Signed-off-by: Aurélien Bombo <[email protected]>
@sprt
Copy link
Contributor Author

sprt commented Nov 7, 2024

Thanks @afinn12! Just updated the PR.

Copy link
Contributor

@afinn12 afinn12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sprt sprt merged commit 054713a into main Nov 7, 2024
1 check passed
afinn12 pushed a commit to a1icja/kata-containers.github.io that referenced this pull request Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants