Skip to content

dashboard: Add Maintainers List #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 22, 2024
Merged

dashboard: Add Maintainers List #29

merged 1 commit into from
Nov 22, 2024
+265 −11

Conversation

afinn12
Copy link
Contributor

@afinn12 afinn12 commented Nov 7, 2024 •
edited
Loading

Needed

  • Merge dashboard: small enhancements #20 before this
    • For instance, the changes to the basePath in deploy.yml/next.config.js is done in that PR. We assume these changes.

Description

  • Added Maintainer information to the rowExpansionTemplate
    • If none exist, a message appears
    • If multiple exist (across groups as well), all names are listed
    • Clicking on the name takes you to their Github
    • On hover, an overlay panel appear with more information
      • Including: Group, Email, Github, and Slack
        • Github and slack are clickable links

Testing

  • Tested in dev
  • Tested in prod

Example of Maintainer's List

image

Example of Overlay Panel

image

@afinn12 afinn12 marked this pull request as ready for review November 7, 2024 20:45
@sprt
Copy link
Contributor

sprt commented Nov 13, 2024

To update UI as such:

Maintainers:
Rust: NameA, NameB
S390x: NameC, NameD NameA

@afinn12
Copy link
Contributor Author

afinn12 commented Nov 18, 2024

Description

  • Maintainers are listed by group with a drop-down panel displaying their contact information. Github/slack are links.
    image

  • Name's won't split, but will still wrap.
    image

a1icja
a1icja reviewed Nov 18, 2024
View reviewed changes
pages/index.js
<div>No Nightly Runs associated with this job</div>
)}
</div>
<div className="mt-4 p-2 bg-gray-300 w-full">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a really long section. Any way to break this up?

sprt
sprt requested changes Nov 19, 2024
View reviewed changes
AdithyaKrishnan
AdithyaKrishnan reviewed Nov 19, 2024
View reviewed changes
stevenhorsman
stevenhorsman approved these changes Nov 20, 2024
View reviewed changes
Copy link
Member

@stevenhorsman stevenhorsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks fine as an initial version, that we can interatively improve. Thanks!

@afinn12
dashboard: Add Maintainers List
1bd9f88 
Added a Maintainer's list for each job, if a mapping exists.
Contains group name, full name, email, Github, and slack information.

Fixes: kata-containers#5

Signed-off-by: Anna Finn <[email protected]>
@sprt sprt merged commit 1ab6ca8 into kata-containers:main Nov 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sprt sprt sprt approved these changes

@stevenhorsman stevenhorsman stevenhorsman approved these changes

+2 more reviewers

@a1icja a1icja a1icja left review comments

@AdithyaKrishnan AdithyaKrishnan AdithyaKrishnan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@afinn12 @sprt @AdithyaKrishnan @a1icja @stevenhorsman