ui: Open job links in new tab #39
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Dashboard component to ensure that job links open in a new tab, accommodating changes in Github's iframe origin policy.
- Updated job link anchor tags to include target="_blank" and rel="noopener noreferrer" for security.
It seems that Github recently changed their iframe origin policy, meaning that opening links in the same iframe/tab doesn't work anymore. To address this, we now open all links in a new tab. Signed-off-by: Aurélien Bombo <[email protected]>
stevenhorsman
approved these changes
Mar 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that Github recently changed their iframe origin policy, meaning that opening links in the same iframe/tab doesn't work anymore. To address this, we now open all links in a new tab.