✨ Add .WithCluster and .WithNamespace #48
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kcp-ci-bot
added
do-not-merge/work-in-progress
ntnn
changed the title
ntnn
changed the title
kcp-ci-bot
removed
the
do-not-merge/work-in-progress
ntnn
force-pushed
the
update-code-gen-third_party
branch
from
8458363 to
09a93ab
Compare
kcp-ci-bot
added
size/XS
ntnn
changed the title
kcp-ci-bot
added
the
do-not-merge/work-in-progress
Signed-off-by: Nelo-T. Wallus <[email protected]>
ntnn
force-pushed
the
update-code-gen-third_party
branch
from
09a93ab to
678b79a
Compare
kcp-ci-bot
added
size/M
ntnn
changed the title
kcp-ci-bot
removed
the
do-not-merge/work-in-progress
|
/lgtm |
|
LGTM label has been added. Git tree hash: 7a6c2655ae724abc2fc05f9ec8876a703e93c3c5
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mjudeikis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kcp-ci-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Will be needed for a PR in code-generator.
I'd remove the NewNamespaced in a later iteration.
The NewNamespaced is actually fine, the problem is the with this pattern two
NewClusteredwould exist. So it is easier to use a method.Alternatively it'd turn in
NewResourceClsuterIndexer(...)andNewResourceIndexerWithClusterAlso marking as WIP as I want to see if we can reduce to just
ResourceIndexer.Edit: Yeah that comes with a whole bunch of other things. Maybe in the future.
Required for this PR: kcp-dev/code-generator#112
To produce this code: https://github.com/ntnn/kcp-client-go/blob/6da9f49cb6ae465ade077a00666498890b21005a/listers/core/v1/resourcequota.go#L32-L116
Related issue(s)
Related: #47