Skip to content

Conversation

ntnn
Copy link
Member

@ntnn ntnn commented Jul 28, 2025

Signed-off-by: Nelo-T. Wallus [email protected]<!--
Thanks for creating a pull request!

If this is your first time, please make sure to review CONTRIBUTING.MD.

Please copy the appropriate :text: or icon to the beginning of your PR title:

✨ ✨ feature
🐛 🐛 bug fix
📖 📖 docs
📝 📝 proposal
⚠️ ⚠️ breaking change
🌱 🌱 other/misc
❓ ❓ requires manual review/categorization

-->

Summary

Related issue(s)

Fixes #

@kcp-ci-bot kcp-ci-bot added dco-signoff: yes Indicates the PR's author has signed the DCO. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 28, 2025
Copy link
Member

@embik embik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 28, 2025
@kcp-ci-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b7883fb3f33a8e9f4eaf92cecd4662f4147b65c4

@mjudeikis
Copy link
Contributor

✨ ✨ feature
🐛 🐛 bug fix
📖 📖 docs
📝 📝 proposal
⚠️ ⚠️ breaking change
🌱 🌱 other/misc
❓ ❓ requires manual review/categorization

lol :D

/approve
/lgtm

@kcp-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: embik, mjudeikis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 28, 2025
@embik
Copy link
Member

embik commented Jul 28, 2025

/retest

Hello @kcp-ci-bot, you out there?

@kcp-ci-bot kcp-ci-bot merged commit 0355faa into kcp-dev:kcp-1.33.3 Jul 28, 2025
8 checks passed
@ntnn ntnn deleted the kcp-1.33.3 branch July 28, 2025 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants