Add OIDC configuration support #68
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kcp-ci-bot
added
kind/feature
kcp-ci-bot
added
the
do-not-merge/work-in-progress
|
Still testing if we really need it on "shards" |
kcp-ci-bot
removed
the
do-not-merge/work-in-progress
mjudeikis
force-pushed
the
mjudeikis/oidc.config
branch
from
62142e8 to
058ef47
Compare
|
/retest |
ntnn
approved these changes
Jul 7, 2025
|
LGTM label has been added. Git tree hash: 6d5eb0810976bcdab0417aa040f0f85d709cb174
|
|
Adding that here would be overboard but in the future we could support taking an Similar to how the helm charts are doing it now. |
embik
reviewed
Jul 8, 2025
Signed-off-by: Mangirdas Judeikis <[email protected]> On-behalf-of: SAP <[email protected]>
mjudeikis
force-pushed
the
mjudeikis/oidc.config
branch
from
058ef47 to
f6826f5
Compare
|
LGTM label has been added. Git tree hash: 48adfaf7c05fe5404a9c19bf21d3370a164f198b
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: embik The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kcp-ci-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
What Type of PR Is This?
/kind feature
Related Issue(s)
Fixes #
Release Notes