Skip to content

extend front-proxy server cert DNSNames with namespaced and cluster-global DNS names #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 27, 2025
Merged

extend front-proxy server cert DNSNames with namespaced and cluster-global DNS names #83

merged 1 commit into from
Aug 27, 2025

Conversation

xrstf
Copy link
Contributor

@xrstf xrstf commented Aug 20, 2025

Summary

This extends the list of domains in the serving cert for the front-proxy from

  • $fpService
  • $rootShardExternalName

by

  • $fpService.$namespace
  • $fpService.$namespace.svc.cluster.local

What Type of PR Is This?

/kind feature

Release Notes

The serving cert for front-proxies now includes the namespaced (`serviceName.namespace`) fully-qualified (`serviceName.namespace.svc.cluster.local`) names of the front-proxy Service.

@kcp-ci-bot kcp-ci-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. dco-signoff: yes Indicates the PR's author has signed the DCO. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 20, 2025
@xrstf xrstf requested a review from SimonTheLeg August 20, 2025 14:44
@SimonTheLeg
Copy link
Contributor

/approve
/lgtm

@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 27, 2025
@kcp-ci-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d7851c775372ed589eadbd0bf51a03bdc2a712c9

@xrstf
Copy link
Contributor Author

xrstf commented Aug 27, 2025

/approve

@kcp-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SimonTheLeg, xrstf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 27, 2025
@kcp-ci-bot kcp-ci-bot merged commit 887d515 into kcp-dev:main Aug 27, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SimonTheLeg SimonTheLeg Awaiting requested review from SimonTheLeg

Assignees

@SimonTheLeg SimonTheLeg

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xrstf @SimonTheLeg @kcp-ci-bot