Use multicluster.Aware in provider.Start function signature #23
+2
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On-behalf-of: SAP <[email protected]> Signed-off-by: Marvin Beckers <[email protected]>
kcp-ci-bot
added
release-note
|
/hold for discussion. |
kcp-ci-bot
added
do-not-merge/hold
|
LGTM label has been added. Git tree hash: 0b84ba0deb74a1be1baa673cd74d0178978d784c
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: xrstf The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kcp-ci-bot
added
the
approved
|
We turned out to use the mcmanager after all, so this PR might not be needed anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is not necessarily something to merge, more of a RFC. I realized we were only using
Engagein the provider startup, and it seemed to me it would be a nice idea to usemulticluster.Awareinstead of the wholemcmanager.Managerkitchen sink. This way, you can use the provider in more custom scenarios (in specific, @xrstf and I are currently re-thinking the api-syncagent to move it to multicluster-runtime, and we might not even use themcmanager.Managerdirectly).Any thoughts on this?
What Type of PR Is This?
/kind cleanup
/kind api-change
Related Issue(s)
Fixes #
Release Notes