Skip to content

Conversation

@xmudrii
Copy link
Member

@xmudrii xmudrii commented Oct 29, 2025

The publishing-bot repos have two remotes: origin (pointing to the real repo) and upstream (pointing to the clone of kcp-dev/kcp). Hence, the previously implemented tags handling logic didn't work at all. Additionally, Go pseudo-version strings are a bit more complicated than originally anticipated. We are now handling the following scenarios:

  • the latest commit has a tag -> return tag as module version
  • the repo does not have tags at all -> return v0.0.0-<commit-timestamp>-<commit-hash>
  • the latest tag in the repo is a prerelease tag -> return <tag>.0.<commit-timestamp>-<commit-hash>
  • the latest tag in the repo is a stable version tag -> return v<major>.<minor>.<patch+1>-0.<commit-timestamp>-<commit-hash>
  • the latest tag's major version does not match the module's major version -> return <tag>+incompatible

/assign @xrstf

On-behalf-of: @SAP [email protected]
Signed-off-by: Marko Mudrinić <[email protected]>
@kcp-ci-bot kcp-ci-bot added dco-signoff: yes Indicates the PR's author has signed the DCO. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 29, 2025
@xrstf
Copy link

xrstf commented Oct 29, 2025

/approve
/lgtm

@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 29, 2025
@kcp-ci-bot
Copy link

LGTM label has been added.

Git tree hash: a29965c03aa6e432e88717fff21c43ece3ec2125

@kcp-ci-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xrstf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 29, 2025
@kcp-ci-bot kcp-ci-bot merged commit a2992ce into kcp-dev:master Oct 29, 2025
6 checks passed
@xmudrii xmudrii deleted the non-v0-tags-fix branch October 29, 2025 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants