Skip to content

フロントエンドでのalgo-ratedの判定条件を修正 #1465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

フロントエンドでのalgo-ratedの判定条件を修正 #1465

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d42eb29
フロントエンドにおけるAlgo Ratedの判定条件をバックエンドと同等に修正
hotate29 Feb 8, 2024
89c1482
バックエンドから取得したRated Point Sumを使うようにリファクタリングした
hotate29 Feb 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 3 additions & 34 deletions atcoder-problems-frontend/src/pages/UserPage/AchievementBlock/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@ import React from "react";
import { Badge, Col, Row, UncontrolledTooltip } from "reactstrap";
import {
useUserACRank,
useContests,
useContestToProblems,
useFastRanking,
useFirstRanking,
useProblemModelMap,
Expand All @@ -12,22 +10,16 @@ import {
useUserSumRank,
useUserSubmission,
} from "../../../api/APIClient";
import {
caseInsensitiveUserId,
isAccepted,
ordinalSuffixOf,
} from "../../../utils";
import { caseInsensitiveUserId, ordinalSuffixOf } from "../../../utils";
import { formatMomentDate, getToday } from "../../../utils/DateUtil";
import { RankingEntry } from "../../../interfaces/RankingEntry";
import { ContestId, ProblemId } from "../../../interfaces/Status";
import { ProblemId } from "../../../interfaces/Status";
import ProblemModel, {
isProblemModelWithTimeModel,
} from "../../../interfaces/ProblemModel";
import { calculateTopPlayerEquivalentEffort } from "../../../utils/ProblemModelUtil";
import Problem from "../../../interfaces/Problem";
import * as UserUtils from "../UserUtils";
import { calcStreak, countUniqueAcByDate } from "../../../utils/StreakCounter";
import { isRatedContest } from "../../../utils/ContestClassifier";

const findFromRanking = (
ranking: RankingEntry[],
Expand All @@ -53,9 +45,6 @@ interface Props {
}

export const AchievementBlock: React.FC<Props> = (props) => {
const contests = useContests().data ?? [];
const contestToProblems =
useContestToProblems() ?? new Map<ContestId, Problem[]>();
const userSubmissions = useUserSubmission(props.userId) ?? [];
const problemModels = useProblemModelMap();
const dailyCount = countUniqueAcByDate(userSubmissions);
Expand All @@ -74,29 +63,9 @@ export const AchievementBlock: React.FC<Props> = (props) => {
const firstRank = findFromRanking(firstRanking, props.userId);
const fastRank = findFromRanking(fastRanking, props.userId);

const ratedProblemIds = new Set(
contests
.flatMap((contest) => {
const contestProblems = contestToProblems.get(contest.id);
const isRated = isRatedContest(contest, contestProblems?.length ?? 0);
return isRated && contestProblems ? contestProblems : [];
})
.map((problem) => problem.id)
);
const acceptedRatedSubmissions = userSubmissions
.filter((s) => isAccepted(s.result))
.filter((s) => ratedProblemIds.has(s.problem_id));
acceptedRatedSubmissions.sort((a, b) => a.id - b.id);
const ratedPointMap = new Map<ProblemId, number>();
acceptedRatedSubmissions.forEach((s) => {
ratedPointMap.set(s.problem_id, s.point);
});
const ratedPointSum = Array.from(ratedPointMap.values()).reduce(
(sum, point) => sum + point,
0
);
const sumRankEntry = useUserSumRank(props.userId);
const sumRank = sumRankEntry.data?.rank;
const ratedPointSum = sumRankEntry.data?.count;

const achievements = [
{
Expand Down
2 changes: 1 addition & 1 deletion atcoder-problems-frontend/src/utils/ContestClassifier.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ export const isRatedContest = (
return (
contest.rate_change !== "-" &&
contest.start_epoch_second >= AGC_001_START &&
problemCount >= 2
problemCount >= 3
);
};

Expand Down