Skip to content

Conversation

divyashreepathihalli
Copy link
Collaborator

No description provided.

Copy link

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

Copy link
Collaborator

@abheesht17 abheesht17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Quick review


**Example Structure**:
```python
@keras_hub_export("keras_hub.models.MyModelBackbone")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does GCA not read the repo at all, which is why we have to provide examples here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure - this is how they have provided their examples - https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a great question, @abheesht17! To clarify, I do analyze the code within the repository. However, providing explicit examples within a style guide like this is incredibly valuable for several reasons:

  1. Clarity and Precision: Examples help to unambiguously define the expected patterns and conventions, especially for nuanced or project-specific rules that might not be immediately obvious from general best practices.
  2. Consistency: They ensure that I, and any human reviewer, apply the rules consistently across the codebase.
  3. Customization: As @divyashreepathihalli pointed out with the link to the documentation, these examples are crucial for customizing my behavior. They serve as direct instructions on how to interpret and apply the style guide's principles to your specific project.

So, while I can read the repo, these examples act as a precise blueprint for how you want me to conduct reviews according to your team's standards.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh haha!!

Copy link
Collaborator

@abheesht17 abheesht17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@divyashreepathihalli divyashreepathihalli merged commit d8e9f88 into keras-team:master Aug 25, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants