-
Notifications
You must be signed in to change notification settings - Fork 306
Add Gemma3 Conversion script to port weights from HF directly #2445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add Gemma3 Conversion script to port weights from HF directly #2445
Conversation
Summary of ChangesHello @laxmareddyp, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly expands KerasHub's capabilities by adding comprehensive support for Gemma3 models. It provides the necessary infrastructure to convert Gemma3 model architectures and weights from Hugging Face, integrates this conversion into the existing preset loading system, and offers a dedicated tool for converting and validating Gemma3 checkpoints, ensuring seamless interoperability and ease of use for Keras developers. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds a conversion script for Gemma3 models, allowing weights to be ported directly from Hugging Face. The changes include the main conversion logic in convert_gemma3.py, updates to preset_loader.py to recognize Gemma3 models, and a new checkpoint conversion script convert_gemma3_hf_checkpoints.py for validation.
The implementation is well-structured and follows the existing patterns for model conversion in the repository. The validation script is comprehensive, checking for parameter count, tokenizer output, and model logits, which is great for ensuring correctness.
My main feedback is on the convert_gemma3.py file, where some of the weight transformation logic can be refactored into helper functions to improve readability and reduce code duplication. This is a minor point on an otherwise solid contribution.
Description of the change
Reference
Colab Notebook
Checklist