update a small feature in __getitem__ for openvino backend #21407
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #21407 +/- ##
==========================================
- Coverage 82.72% 82.72% -0.01%
==========================================
Files 565 565
Lines 55219 55221 +2
Branches 8608 8609 +1
==========================================
Hits 45682 45682
- Misses 7427 7429 +2
Partials 2110 2110
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fchollet
reviewed
Jun 23, 2025
keras/src/backend/openvino/core.py
Outdated
| elif isinstance(index, (int, np.integer, np.ndarray)): | ||
| if isinstance(index, (np.ndarray, np.integer)): | ||
| if isinstance(index, np.ndarray): | ||
| assert len(index.shape) == 0, ( |
Collaborator
There was a problem hiding this comment.
Please use ValueError instead of assert.
Mohamed-Ashraf273
force-pushed
the
getitem
branch
from
2336655 to
0466f3b
Compare
Contributor
Author
Contributor
|
@fchollet, looks good to me. Recommend to merge |
Mohamed-Ashraf273
added a commit
to Mohamed-Ashraf273/keras
that referenced
this pull request
Jul 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @fchollet
I just added a check for
np.ndarrayin the function that was recently merged.